-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding staking rewards and asset functionality #10
Conversation
✅ Heimdall Review Status
|
pkg/coinbase/staking_reward.go
Outdated
|
||
for page != "" { | ||
|
||
if page == "first" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this paradigm to mimic how we were doing this for the other SDKs but I can update it based on your recommendation below.
pkg/coinbase/staking_reward.go
Outdated
Format: format, | ||
} | ||
|
||
for page != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just use for {} ? and exit when no more pages ?
What changed? Why?
Add the ability to query staking rewards for an addreses.
Add the Asset object and ability to fetch an asset from the backend server.
Testing
Output of the example:
Qualified Impact