Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add icons types #45

Closed
wants to merge 5 commits into from
Closed

add icons types #45

wants to merge 5 commits into from

Conversation

dependentmadani
Copy link
Contributor

Trying to solve the issue #44, @neSpecc can you please check this?

neSpecc
neSpecc reviewed Jul 1, 2024
View reviewed changes
neSpecc
neSpecc reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, improve the PR description explaining what was the cause of the problem and what is the solution for that

@dependentmadani
Copy link
Contributor Author

Description of new pull request:

  • Remove the created types folder and file of every type created manually.
  • Add a line in generate.js file to add type for every icon, and it will be build in index.d.ts.

neSpecc
neSpecc reviewed Jul 2, 2024
View reviewed changes
@dependentmadani
Copy link
Contributor Author

Description of last modification:

  • Add the export of types in packages.json
  • Remove all previous modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dependentmadani @neSpecc