Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve log information #656

Merged
merged 2 commits into from
Dec 19, 2023
Merged

chore: improve log information #656

merged 2 commits into from
Dec 19, 2023

Conversation

emizzle
Copy link
Contributor

@emizzle emizzle commented Dec 18, 2023 •
edited
Loading

  1. Add downtime information to the validator logs that provides information that proofs were not marked as missing due to being in downtime. This can help understand why proofs were not marked as missing.
  2. Add previous state to the state machine transition log. This helps when debugging, particularly when entering the errored state, eg SaleErrored.

This PR is part of reducing the size of a much larger PR: #607

@emizzle emizzle changed the title chore: improve logging chore: improve log information Dec 18, 2023
@emizzle emizzle force-pushed the chore/validator/downtime-logging branch from eb67a1d to c5bf7c5 Compare December 18, 2023 09:36
@emizzle emizzle force-pushed the chore/validator/downtime-logging branch from c5bf7c5 to 5777bb7 Compare December 19, 2023 00:56
@emizzle emizzle force-pushed the chore/validator/downtime-logging branch from 5777bb7 to 149ed63 Compare December 19, 2023 01:31
@emizzle emizzle enabled auto-merge (squash) December 19, 2023 01:33
@emizzle emizzle merged commit 2c621e0 into master Dec 19, 2023
8 checks passed
@emizzle emizzle deleted the chore/validator/downtime-logging branch December 19, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbierens benbierens benbierens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emizzle @benbierens