Skip to content

Commit

Permalink
bump ethers, remove upraises from callbacks (#664)
Browse files Browse the repository at this point in the history
  • Loading branch information
emizzle authored Jan 9, 2024
1 parent fffb674 commit b186afb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion codex.nimble
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ requires "bearssl >= 0.1.4"
requires "chronicles >= 0.7.2"
requires "chronos >= 2.5.2"
requires "confutils"
requires "ethers >= 0.7.0 & < 0.8.0"
requires "ethers >= 0.7.1 & < 0.8.0"
requires "libbacktrace"
requires "libp2p"
requires "metrics"
Expand Down
2 changes: 1 addition & 1 deletion codex/contracts/clock.nim
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ method start*(clock: OnChainClock) {.async.} =
if clock.started:
return

proc onBlock(blck: Block) {.upraises:[].} =
proc onBlock(blck: Block) =

This comment has been minimized.

Copy link
@dryajov

dryajov Jan 9, 2024

Contributor

Should still have a raises: []

This comment has been minimized.

Copy link
@dryajov

dryajov Jan 9, 2024

Contributor

In fact all callbacks should

let blockTime = initTime(blck.timestamp.truncate(int64), 0)
let computerTime = getTime()
clock.offset = blockTime - computerTime
Expand Down
2 changes: 1 addition & 1 deletion vendor/nim-ethers

0 comments on commit b186afb

Please sign in to comment.