Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two easy optimizations #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

egonelbre
Copy link

Also, I'm not certain that I didn't break anything.

@zaydek
Copy link
Member

zaydek commented Feb 13, 2020

Hey Egon, that’s so nice of you.

Yeah, this is one of the optimizations needed to improve the current architecture. I plan on merging this when I get back to working on the editor.

Thanks!

If you’re interested in running the Editor test suite in the future, in theory you should be able to run yarn test-editor-chrome -- there’s also test-editor-firefox and text-editor-safari, but I don’t know how well those are expected to work cross-platform. I should probably setup CI to automate it.

@zaydek zaydek force-pushed the master branch 2 times, most recently from b763d93 to 769c141 Compare May 31, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants