Skip to content

Commit a49fbbb

Browse files
fix: run code-server as the appropriate user (#1)
1 parent 8f79b61 commit a49fbbb

File tree

7 files changed

+7
-6
lines changed

7 files changed

+7
-6
lines changed

.github/workflows/test.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ jobs:
1515
features:
1616
- code-server
1717
baseImage:
18+
- fedora:latest
1819
- debian:latest
1920
- ubuntu:latest
2021
- mcr.microsoft.com/devcontainers/base:ubuntu

src/code-server/install.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ cat > /usr/local/bin/code-server-entrypoint \
2222
#!/usr/bin/env bash
2323
set -e
2424
25-
code-server --bind-addr "$HOST:$PORT" \$ARGS
25+
su $_REMOTE_USER -c 'code-server --bind-addr "$HOST:$PORT" \$ARGS'
2626
EOF
2727

2828
chmod +x /usr/local/bin/code-server-entrypoint

test/code-server/code-server-extensions.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ source dev-container-features-test-lib
77
# Feature-specific tests
88
check "code-server version" code-server --version
99
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
10-
check "code-server listening" sudo lsof -i "@0.0.0.0:8080"
10+
check "code-server listening" lsof -i "@0.0.0.0:8080"
1111

1212
extensions=$(sudo code-server --list-extensions)
1313

test/code-server/code-server-install-version.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ source dev-container-features-test-lib
77
# Feature-specific tests
88
check "code-server version" code-server --version
99
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
10-
check "code-server listening" sudo lsof -i "@0.0.0.0:8080"
10+
check "code-server listening" lsof -i "@0.0.0.0:8080"
1111

1212
version=$(code-server --version)
1313
check "code-server is correct version" grep '4.98.0\>' <<<"$version"

test/code-server/code-server-modified-host.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ source dev-container-features-test-lib
77
# Feature-specific tests
88
check "code-server version" code-server --version
99
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
10-
check "code-server listening" sudo lsof -i "@0.0.0.0:8080"
10+
check "code-server listening" lsof -i "@0.0.0.0:8080"
1111

1212
# Report results
1313
reportResults

test/code-server/code-server-modified-port.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ source dev-container-features-test-lib
77
# Feature-specific tests
88
check "code-server version" code-server --version
99
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
10-
check "code-server listening" sudo lsof -i "@127.0.0.1:1234"
10+
check "code-server listening" lsof -i "@127.0.0.1:1234"
1111

1212
# Report results
1313
reportResults

test/code-server/test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ source dev-container-features-test-lib
77
# Feature-specific tests
88
check "code-server version" code-server --version
99
check "code-server running" pgrep -f 'code-server/lib/node.*/code-server'
10-
check "code-server listening" sudo lsof -i "@127.0.0.1:8080"
10+
check "code-server listening" lsof -i "@127.0.0.1:8080"
1111

1212
# Report results
1313
reportResults

0 commit comments

Comments
 (0)