Add option to configure and build without graphics #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the configuration and build of graphical demos and their dependencies (Magnum, Corrade, SDL2) depend on a new CMake cache variable ENABLE_GRAPHICS. Auto-configure this new variable based on the result of find_package(SDL2). A warning is emitted if ENABLE_GRAPHICS is unset and SDL2 is not found. The warning can be silenced by explicitly setting the option to OFF. In case the option is explicitly set to ON and SDL2 is not found, a fatal error is emitted. Add an explanation of the new option in the README. Add a new CI step building the no-graphics version. Set ENABLE_GRAPHICS=ON explicitly in the baseline CI build.
DuncanMcBain
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the configuration and build of graphical demos and their dependencies (Magnum, Corrade, SDL2) depend on a new CMake cache variable
ENABLE_GRAPHICS. Auto-configure this new variable based on the result offind_package(SDL2).A warning is emitted if
ENABLE_GRAPHICSis unset and SDL2 is not found. The warning can be silenced by explicitly setting the option to OFF. In case the option is explicitly set to ON and SDL2 is not found, a fatal error is emitted. In summary, the auto-configuration forENABLE_GRAPHICSworks as follows:ENABLE_GRAPHICSAdd an explanation of the new option in the README.
Add a new CI step building the no-graphics version using stock
intel/oneapi-basekitcontainer. SetENABLE_GRAPHICS=ONexplicitly in the baseline CI build.