Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in initial e2e tests for cloud operator. #447

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jmcarp
Copy link

@jmcarp jmcarp commented Jan 17, 2025

Add a test to deploy the operator, then a single-node crdb cluster, and test basic functionality.

@jmcarp jmcarp requested a review from pritesh-lahoti January 17, 2025 18:05
@jmcarp jmcarp force-pushed the jmcarp/poc-deploy-operator-e2e branch 4 times, most recently from 304c916 to fcb5c37 Compare January 17, 2025 21:56
Copy link
Contributor

@pritesh-lahoti pritesh-lahoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving


if rotate {
t.Log("Verifying the existing data in the database after certificate rotation")
}

// Create database only if we are testing crdb install
if !rotate {
if _, err := db.Exec("CREATE DATABASE test_db"); err != nil {
if _, err := db.Exec("CREATE DATABASE IF NOT EXISTS testdb"); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if _, err := db.Exec("CREATE DATABASE IF NOT EXISTS testdb"); err != nil {
if _, err := db.Exec("CREATE DATABASE IF NOT EXISTS test_db"); err != nil {

Looks like this is causing the test to fail on CI.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed!

@jmcarp jmcarp force-pushed the jmcarp/poc-deploy-operator-e2e branch 2 times, most recently from 9d4c808 to 8a26b04 Compare January 27, 2025 18:29
Add an e2e test that installs the operator, then a crdbcluster, and
makes assertions about basic crdb functionality.
@jmcarp jmcarp force-pushed the jmcarp/poc-deploy-operator-e2e branch from 8a26b04 to 70f30fa Compare January 27, 2025 18:41
@jmcarp jmcarp merged commit ebd8f6f into poc-deploy-operator Jan 27, 2025
8 checks passed
@jmcarp jmcarp deleted the jmcarp/poc-deploy-operator-e2e branch January 27, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants