Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRDB-44997] feature: support WAL failover #436

Merged
merged 1 commit into from
Dec 18, 2024
Merged

[CRDB-44997] feature: support WAL failover #436

merged 1 commit into from
Dec 18, 2024

Conversation

pritesh-lahoti
Copy link
Contributor

Adds support for WAL failover via:

  • among multiple stores
  • single store side disk (as a PVC)

@pritesh-lahoti pritesh-lahoti changed the title feature: support WAL failover [CRDB-44997] feature: support WAL failover Dec 11, 2024
@pritesh-lahoti pritesh-lahoti marked this pull request as ready for review December 11, 2024 12:01
prafull01
prafull01 reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@prafull01 prafull01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add upgrade documentation when number of datastore changes as it is not traditional upgrade for user.

We should also add an e2e test which covers the migration scenario with upgrade. If we decide to do it later, please add a ticket for the same

@pritesh-lahoti
Copy link
Contributor Author

We should add upgrade documentation when number of datastore changes as it is not traditional upgrade for user.

We should also add an e2e test which covers the migration scenario with upgrade. If we decide to do it later, please add a ticket for the same

Will track the documentation separately. Updated the PR with an e2e test.

@pritesh-lahoti pritesh-lahoti force-pushed the wal-failover branch 3 times, most recently from 9f27e37 to e89d50c Compare December 17, 2024 18:00
@pritesh-lahoti pritesh-lahoti force-pushed the wal-failover branch 5 times, most recently from 3499f17 to e0852f6 Compare December 18, 2024 12:06
@pritesh-lahoti
[CRDB-44997] feature: support WAL failover
28168fd 
Adds support for WAL failover via:
- among multiple stores
- single store side disk (as a PVC)
@pritesh-lahoti pritesh-lahoti merged commit b9731bc into master Dec 18, 2024
9 checks passed
@pritesh-lahoti pritesh-lahoti deleted the wal-failover branch December 18, 2024 12:44
@pritesh-lahoti pritesh-lahoti restored the wal-failover branch December 18, 2024 13:41
@pritesh-lahoti pritesh-lahoti deleted the wal-failover branch December 18, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prafull01 prafull01 prafull01 approved these changes

@BabuSrithar BabuSrithar Awaiting requested review from BabuSrithar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pritesh-lahoti @BabuSrithar @prafull01