Automerge version bumps #390
Merged
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celiala
approved these changes
May 23, 2024
| branches: [ master ] | ||
| paths: | ||
| # Trigger the workflow only for certain files. First we need to exclude all | ||
| # files, then add the files we care about. |
.github/workflows/automerge.yaml
Outdated
| # files. We restore the changed files to their original state on the | ||
| # default branch, run the commands to regenerate the change, and verify | ||
| # the result matches the PR contents (git diff does not show any changes). | ||
| - name: Regenerate the patch |
There was a problem hiding this comment.
nit: maybe name this "confirm expected patch" or something?
(then under "verify nothing changed" move the build steps in there, i.e.)
bazel build //build
$(bazel info bazel-bin)/build/build_/build bump "$appVersion"
There was a problem hiding this comment.
I'll rename the step. 👍
The build steps generate the patch, so they kind of belong to this step IMO.
There was a problem hiding this comment.
ah, gotcha. cool, works for me :) 👍🏼
This change marks PRs created by `cockroach-teamcity` ready to be merged after all checks are passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change marks PRs created by
cockroach-teamcityready to be merged after all checks are passed.