Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminationGracePeriodSeconds to 300 seconds #378

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

prafull01
Copy link
Collaborator

@prafull01 prafull01 commented Feb 26, 2024

We've extended the terminationGracePeriodSeconds to 300 seconds for the CockroachDB StatefulSet, allowing up to 300 seconds for termination of the pod. Consequently, we need to adjust the Helm upgrade timeout accordingly for a standard 3-node CockroachDB cluster.

@prafull01 prafull01 force-pushed the update-termination-seconds branch from 243aa18 to c62f049 Compare February 26, 2024 12:08
@prafull01 prafull01 force-pushed the update-termination-seconds branch from c62f049 to e6672e6 Compare February 26, 2024 14:06
@prafull01 prafull01 requested a review from rail February 26, 2024 14:13
Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@prafull01 prafull01 merged commit 704b416 into cockroachdb:master Feb 26, 2024
9 checks passed
@prafull01 prafull01 deleted the update-termination-seconds branch February 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants