Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-12343 Add missing quotes in --exclude-files example for cockroach debug zip #19391

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Feb 19, 2025

Fixed DOC-12343

In cockroach-debug-zip.md, updated examples for --exclude-files and --include-files flags.

Rendered preview

Copy link

Files changed:

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit f2bf8a5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67b74bc82460030008b63f96

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit f2bf8a5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67b74bc861d61d0008a39e6c

Copy link

netlify bot commented Feb 19, 2025

Netlify Preview

Name Link
🔨 Latest commit f2bf8a5
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67b74bc8aaaf400008d8d7e8
😎 Deploy Preview https://deploy-preview-19391--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl
Copy link
Contributor Author

@Leeeeeeeroy-Jenkins approved in this slack thread.

Matthew Jenkins
all good, gives a couple of examples with syntax so i think that demonstrates the point. Its likely the same id imagine for include?

I updated the examples for --include-files flag.

Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florence-crl florence-crl merged commit 4d38a9b into main Feb 20, 2025
6 checks passed
@florence-crl florence-crl deleted the DOC-12343 branch February 20, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants