Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V25.1.0 ga #19382

Merged
merged 40 commits into from
Feb 18, 2025
Merged

V25.1.0 ga #19382

merged 40 commits into from
Feb 18, 2025

Conversation

shannonbradshaw
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 18, 2025

Files changed:

  • src/current/_config_cockroachdb.yml
  • src/current/_data/releases.yml
  • src/current/_data/versions.csv
  • src/current/_includes/releases/v25.1/backward-incompatible.md:
  • src/current/_includes/releases/v25.1/deprecations.md:
  • src/current/_includes/releases/v25.1/feature-highlights-change-data-capture.html
  • src/current/_includes/releases/v25.1/feature-highlights-cloud.html
  • src/current/_includes/releases/v25.1/feature-highlights-disaster-recovery.html
  • src/current/_includes/releases/v25.1/feature-highlights-kv.html
  • src/current/_includes/releases/v25.1/feature-highlights-licensing.html
  • src/current/_includes/releases/v25.1/feature-highlights-observability.html
  • src/current/_includes/releases/v25.1/feature-highlights-security.html
  • src/current/_includes/releases/v25.1/feature-highlights-sql.html
  • src/current/_includes/releases/v25.1/upgrade-finalization.md:
  • src/current/_includes/releases/v25.1/v25.1.0.md:
  • src/current/releases/cloud.md
  • src/current/v25.1/known-limitations.md

Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 3cece74
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67b4c9c824555300080e6143

Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 3cece74
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67b4c9c85760fd0008abab1f

Copy link

netlify bot commented Feb 18, 2025

Netlify Preview

Name Link
🔨 Latest commit 3cece74
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67b4c9c97aad2d00089d845b
😎 Deploy Preview https://deploy-preview-19382--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


Key improvements include:
<ul>
<li>Full support for check constraints, enabling you to maintain data integrity while modifying column types</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this one about "full support for check constraints" is correct, i just had @spilchen (engineer on this feature) review my docs PR (this line and our public v25.1 docs still say here that "You cannot alter the data type of a column if .. The column has CHECK constraints."

i think the other lines are correct AFAICT

cc @dikshant FYI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm this example works tho

CREATE TABLE users (
    id UUID DEFAULT gen_random_uuid() UNIQUE PRIMARY KEY,
    email VARCHAR(100) NOT NULL DEFAULT 'pending@example.com',
    first_name VARCHAR(50),
    last_name VARCHAR(50),
    status VARCHAR(20) NOT NULL 
        DEFAULT 'active'
        CHECK (status IN ('active', 'inactive', 'pending')),
    created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
    INDEX idx_users_status (status)
);

ALTER TABLE users ALTER COLUMN status TYPE VARCHAR(50);

So I don't know if what you are saying is true either. @spilchen thoughts?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a nuance to this. In the working case above, the column type change (VARCHAR(20) -> VARCHAR(50)) doesn’t trigger a column rewrite—it only updates the column's metadata. Since these types are compatible, the existing CHECK CONSTRAINT remains valid. However, if you were to change VARCHAR to INT, for example, that would require a column rewrite, which would be blocked due to the CHECK CONSTRAINT.

Do we need to clarify the scenarios in which a column rewrite occurs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for release notes we can leave it out. But in docs we will want to cover that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed that bullet from the feature highlight. Thanks for the quick turnaround.

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple corrections on the SQL Queries side. Also, suggesting a change to the backward-incompatible section.

shannonbradshaw and others added 6 commits February 18, 2025 12:51
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Co-authored-by: Ryan Kuo <8740013+taroface@users.noreply.github.com>
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shannonbradshaw shannonbradshaw merged commit 63f1a4d into main Feb 18, 2025
6 checks passed
@shannonbradshaw shannonbradshaw deleted the v25.1.0-ga branch February 18, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants