Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new include for v25.1 Key Cluster Setting Changes #19378

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

mikeCRL
Copy link
Contributor

@mikeCRL mikeCRL commented Feb 14, 2025

DOC-12266

@shannonbradshaw can you please review, feel free to merge if it's good, and then use this as an include in v25.1.0.md under the following heading?

<a name="v24-3-0-cluster-settings"></a>

<h4 id="v24-3-0-key-cluster-setting-changes">Key Cluster Setting Changes</h4>

@mikeCRL mikeCRL marked this pull request as ready for review February 14, 2025 19:41
Copy link

Files changed:

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 40c7243
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67af9c7950ca9a0008068f1f

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 40c7243
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67af9c79714dd000085e9915

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 3366fe2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67b37b5bef1a6500080c8a16

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 3366fe2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67b37b5b2dc6af0008ae3ab9

Copy link

netlify bot commented Feb 14, 2025

Netlify Preview

Name Link
🔨 Latest commit 40c7243
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67af9c79cc695000082db9a9
😎 Deploy Preview https://deploy-preview-19378--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 14, 2025

Netlify Preview

Name Link
🔨 Latest commit 3366fe2
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67b37b5ba2e20f0008a733f9
😎 Deploy Preview https://deploy-preview-19378--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

@mikeCRL mikeCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revising one bullet

@shannonbradshaw
Copy link
Contributor

@mikeCRL I'll merge this tomorrow and include as you suggest. Thanks for wrapping this up.

Copy link
Contributor

@shannonbradshaw shannonbradshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shannonbradshaw shannonbradshaw merged commit 01947f5 into main Feb 17, 2025
7 checks passed
@shannonbradshaw shannonbradshaw deleted the 25.1-cluster-setting-changes branch February 17, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants