-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs on transparent huge pages (THP) setting #19343
base: main
Are you sure you want to change the base?
Conversation
Files changed: |
@RaduBerinde i added this to v25.1 docs so we can verify language what previous versions should also have this guidance? |
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -22,6 +22,15 @@ For optimal cluster performance, Cockroach Labs recommends that all nodes use th | |||
|
|||
We recommend running a [glibc](https://www.gnu.org/software/libc/)-based Linux distribution and Linux kernel version from the last 5 years, such as [Ubuntu](https://ubuntu.com/), [Red Hat Enterprise Linux (RHEL)](https://www.redhat.com/technologies/linux-platforms/enterprise-linux), [CentOS](https://www.centos.org/), or [Container-Optimized OS](https://cloud.google.com/container-optimized-os/docs). | |||
|
|||
New deployments should configure [transparent huge pages (THP)](https://www.kernel.org/doc/html/latest/admin-guide/mm/transhuge.html) with the `madvise` option: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe give a bit of the reasoning: "We have observed (in rare cases) increased memory usage due to transparent huge pages (THP) being enabled (set to always
). New deployments should ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added, PTAL!
@RaduBerinde this may go without saying but I guess since this docs change is about the OS config it can be backported to v23.1+ docs? (once we're happy with it) or are there CRDB-version-related considerations? please advise, thanks! |
Looks great! Yes, we should backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but couple suggestions
|
||
Existing deployments that have THP enabled using the `always` option should change it to `madvise` unless they are currently running with a comfortable memory usage margin. | ||
|
||
The method for permanently changing the THP setting across reboots depends on the operating system. For Red Hat Enterprise Linux, see https://access.redhat.com/solutions/46111. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method for permanently changing the THP setting across reboots depends on the operating system. For Red Hat Enterprise Linux, see https://access.redhat.com/solutions/46111. | |
The method for permanently changing the THP setting across reboots depends on the operating system. For Red Hat Enterprise Linux, refer to the [Red Hat documentation](https://access.redhat.com/solutions/46111). |
@@ -22,6 +22,12 @@ For optimal cluster performance, Cockroach Labs recommends that all nodes use th | |||
|
|||
We recommend running a [glibc](https://www.gnu.org/software/libc/)-based Linux distribution and Linux kernel version from the last 5 years, such as [Ubuntu](https://ubuntu.com/), [Red Hat Enterprise Linux (RHEL)](https://www.redhat.com/technologies/linux-platforms/enterprise-linux), [CentOS](https://www.centos.org/), or [Container-Optimized OS](https://cloud.google.com/container-optimized-os/docs). | |||
|
|||
We have observed increased memory usage in rare cases due to transparent huge pages (THP) being enabled (i.e., set to `always`). New deployments should configure [transparent huge pages (THP)](https://www.kernel.org/doc/html/latest/admin-guide/mm/transhuge.html) with the `madvise` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have observed increased memory usage in rare cases due to transparent huge pages (THP) being enabled (i.e., set to `always`). New deployments should configure [transparent huge pages (THP)](https://www.kernel.org/doc/html/latest/admin-guide/mm/transhuge.html) with the `madvise` option. | |
We have observed increased memory usage in rare cases due to [transparent huge pages (THP)](https://www.kernel.org/doc/html/latest/admin-guide/mm/transhuge.html) being enabled (i.e., set to `always`). New deployments should configure THP with the `madvise` option. |
Fixes DOC-12097