From 1ccf3a14dc5722154a4e653d1e579a0d9f553610 Mon Sep 17 00:00:00 2001 From: Damian Zaremba Date: Thu, 12 Dec 2024 14:49:29 +0000 Subject: [PATCH] core - cleanup split spans --- pkg/cbng/processor/core.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/cbng/processor/core.go b/pkg/cbng/processor/core.go index 34611c0..4049409 100644 --- a/pkg/cbng/processor/core.go +++ b/pkg/cbng/processor/core.go @@ -103,6 +103,7 @@ func isVandalism(l *logrus.Entry, parentCtx context.Context, configuration *conf logger.Tracef("Connecting to %v", coreUrl) _, scoreSpan := metrics.OtelTracer.Start(ctx, "core.isVandalism.score") + defer scoreSpan.End() dialer := net.Dialer{Timeout: time.Second * 5} conn, err := dialer.Dial("tcp", coreUrl) if err != nil { @@ -132,14 +133,14 @@ func isVandalism(l *logrus.Entry, parentCtx context.Context, configuration *conf break } } - defer scoreSpan.End() + scoreSpan.End() logger = logger.WithField("response", response) _, scoreDecodeSpan := metrics.OtelTracer.Start(ctx, "core.isVandalism.score.decode") defer scoreDecodeSpan.End() editSet := model.WPEditScoreSet{} if err := xml.Unmarshal(response, &editSet); err != nil { - scoreSpan.SetStatus(codes.Error, err.Error()) + scoreDecodeSpan.SetStatus(codes.Error, err.Error()) logger.Warnf("Could not decode response: %v", err) return false, err }