Porting opi_recognition to ROS2 #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finished implementing opi recognition
Added launch files Made the publisher change image periodically
IliTheButterfly
changed the title
…ile common.py, and BASE_PATH reffers to the python package rove_opi (rove/src/rove_opi/rove_opi)
SimonR99
reviewed
Apr 5, 2024
There was a problem hiding this comment.
We need to discuss this, I'm not sure rove_opi should be in the rove repo. I think it should be a standalone repo, something like capra_opi. Then we would have .repos that will be in charge of getting it. That way, other teams or even us later on a new robot would be able to reuse it. A simple launchfile in rove_bringup would call the package.
Added repo to rove.repos. Added tesseract install to Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created packages:
rove_opi:
Takes in an image message and returns a polygon message. The polygon is in 2D (only the x and y values of the points are used).
Use
ros2 launch rove_opi opi.launch.pyto run.rove_opi_publisher:
Used for debugging.
Use
ros2 launch rove_opi test_opi.launch.pyto run