Added ipset.Save() at the start of syncNetworkPolicyChains
#1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Bonafiglia <roberto.bonafiglia@suse.com>
aauren
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Thanks for contributing this @rbrtbnfgl!
It looks good to me from a code point of view and also passed all of the standard Kubernetes network integration tests. So I think we're good to go here.
After we get some feedback from @alexcriss or others that are a part of #1732 that this fixes the issue I'll merge and tag it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fixes #1732 to refresh the rules before syncing the policy.