Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using xxhash v2 #577

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Using xxhash v2 #577

merged 1 commit into from
Dec 6, 2024

Conversation

Jobsby
Copy link
Contributor

@Jobsby Jobsby commented Dec 2, 2024

Description

The log-cache-version currently uses the xxhash dependency of version 1.1.0.
This PR updates the xxhash dependency in the log-cache-version to 2.3.0.
Update xxhash from
github.com/cespare/xxhash v1.1.0
to
github.com/cespare/xxhash/v2 v2.3.0.

All imports have been checked and adjusted.
Unit tests have run successfully.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

@Jobsby Jobsby requested a review from a team as a code owner December 2, 2024 11:02
Copy link
Member

@ctlong ctlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctlong ctlong linked an issue Dec 3, 2024 that may be closed by this pull request
@ctlong ctlong self-assigned this Dec 3, 2024
@ctlong ctlong merged commit bf91878 into cloudfoundry:main Dec 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to github.com/cespare/xxhash/v2
2 participants