Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dariquest to app-runtime-interfaces #1061

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Dariquest
Copy link
Contributor

@Dariquest
Copy link
Contributor Author

Dariquest commented Jan 29, 2025

Hi @a-b, @stephanme, as discussed yesterday :)

@Gerg Gerg requested review from Gerg and stephanme and removed request for Gerg January 29, 2025 19:24
@Gerg
Copy link
Member

Gerg commented Jan 29, 2025

cc @cloudfoundry/wg-app-runtime-interfaces-cli-approvers

@Gerg
Copy link
Member

Gerg commented Jan 29, 2025

Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, you need 2 existing CLI approvers to review your application to affirm that you meet the criteria for promotion. Once the review is complete, Stephan or I can merge this PR.

Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as Dari is looking to contribute more to the cli
edit - also pointing out this is for reviewer, not approver, since the title of this PR is not clear

also noted that Dari is missing from https://github.com/cloudfoundry/community/blob/main/org/contributors.yml but maybe contributors.yml doesn't matter anymore? Dari is clearly active based on being a reviewer in other working groups

Dariquest added a commit to Dariquest/community that referenced this pull request Jan 31, 2025
@Dariquest Dariquest mentioned this pull request Jan 31, 2025
@Dariquest
Copy link
Contributor Author

approving as Dari is looking to contribute more to the cli

also noted that Dari is missing from https://github.com/cloudfoundry/community/blob/main/org/contributors.yml but maybe contributors.yml doesn't matter anymore? Dari is clearly active based on being a reviewer in other working groups

Thanks @moleske, I have created a PR for the contributors extension: #1066

@a-b
Copy link
Member

a-b commented Feb 3, 2025

I endorse the inclusion of @Dariquest in ARI.

@stephanme stephanme merged commit ea2bbfe into cloudfoundry:main Feb 4, 2025
2 checks passed
@stephanme
Copy link
Member

Welcome @Dariquest as reviewer in the CLI area of the ARI WG.

@Dariquest Dariquest deleted the patch-2 branch February 4, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants