-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dariquest to app-runtime-interfaces #1061
Conversation
Hi @a-b, @stephanme, as discussed yesterday :) |
cc @cloudfoundry/wg-app-runtime-interfaces-cli-approvers |
Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, you need 2 existing CLI approvers to review your application to affirm that you meet the criteria for promotion. Once the review is complete, Stephan or I can merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving as Dari is looking to contribute more to the cli
edit - also pointing out this is for reviewer, not approver, since the title of this PR is not clear
also noted that Dari is missing from https://github.com/cloudfoundry/community/blob/main/org/contributors.yml but maybe contributors.yml doesn't matter anymore? Dari is clearly active based on being a reviewer in other working groups
Thanks @moleske, I have created a PR for the contributors extension: #1066 |
I endorse the inclusion of @Dariquest in ARI. |
Welcome @Dariquest as reviewer in the CLI area of the ARI WG. |
PRs
Cloud Foundry Route Lookup Plugin:
cloudfoundry/cli-plugin-repo#499
Per-Route Options
cloudfoundry/cli#3372
cloudfoundry/cli#3366
Helper
cloudfoundry/cli#3374
cloudfoundry/cli#3375
cloudfoundry/cli#3376