Add github action for running tests #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/173024538 The labels on this github issue will be updated when the story is started. |
sethboyles
force-pushed
the
github-actions
branch
from
69ad3c6 to
710ad85
Compare
matt-royal
force-pushed
the
github-actions
branch
from
996e84d to
acdee95
Compare
|
This would make us much more effective at reviewing PRs, so I'm taking a stab at getting this working. |
Co-authored-by: Seth Boyles <sboyles@pivotal.io> Co-authored-by: Jaskanwal Pawar <jpawar@pivotal.io> Co-authored-by: Matt Royal <mroyal@pivotal.io>
matt-royal
force-pushed
the
github-actions
branch
from
d176eb7 to
b280cf1
Compare
|
I was able to get the work @sethboyles and @jspawar started to pass. The main issue was that we were using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests