Add logging to internal_build.py

Author: ketanhwr

.github/workflows/internal-build.yml

@@ -26,9 +26,9 @@ jobs:
           CI_CLIENT_SECRET: ${{ secrets.CI_CF_ACCESS_CLIENT_SECRET }}
         run: |
           python3 ./tools/cross/internal_build.py \
-            ${{github.event.pull_request.id}} \
+            ${{github.event.pull_request.number}} \
             ${{github.event.pull_request.head.sha}} \
-            $GITHUB_RUN_ATTEMPT \
+            ${{github.run_attempt}} \
             "${{github.event.pull_request.head.ref}}" \
             $CI_URL \
             $CI_CLIENT_ID \

tools/cross/internal_build.py

@@ -1,7 +1,9 @@
 import argparse
-import requests
-import time
 import sys
+import time
+
+import requests
+
 
 def parse_args():
     parser = argparse.ArgumentParser()
@@ -16,32 +18,35 @@ def parse_args():
 
     return parser.parse_args()
 
+
 if __name__ == "__main__":
     args = parse_args()
 
     # Submit build job
     headers = {
         "CF-Access-Client-Id": args.client_id,
-        "CF-Access-Client-Secret": args.secret
+        "CF-Access-Client-Secret": args.secret,
     }
 
     payload = {
         "pr_id": args.pr_id,
         "commit_sha": args.sha,
         "run_attempt": args.run_attempt,
-        "branch_name": args.branch_name
+        "branch_name": args.branch_name,
     }
 
-    workflow_id = ''
+    workflow_id = ""
     try:
         resp = requests.post(args.URL, headers=headers, json=payload)
         resp.raise_for_status()
 
-        workflow_id = resp.json().id
+        workflow_id = resp.json()["workflow_id"]
     except Exception as err:
         print(f"Unexpected error {err=}, {type(err)=}")
         sys.exit(1)
 
+    print("Internal build submitted")
+
     time.sleep(30)
 
     # Poll build status
@@ -50,15 +55,18 @@ def parse_args():
 
     while failed_requests < FAILED_REQUEST_LIMIT:
         try:
-            resp = requests.get(args.URL, headers=headers, params={ 'id': workflow_id })
+            resp = requests.get(args.URL, headers=headers, params={"id": workflow_id})
             resp.raise_for_status()
 
-            status = resp.json().status
+            status = resp.json()["status"]
             if status == "errored":
+                print("Build failed")
                 sys.exit(1)
             elif status == "complete":
                 break
 
+            print("Waiting for build to finish..")
+
         except Exception as err:
             print(f"Unexpected error {err=}, {type(err)=}")
             failed_requests = failed_requests + 1
@@ -68,4 +76,3 @@ def parse_args():
         sys.exit(1)
 
     print("Internal build succeeded")
-