Roll V8 to 13.3 (#3417)

* Roll V8 to 13.3

* Try to get highway bindings right

* Update abseil, zlib and icu to match V8 13.3.

* Improve compatibility with V8 13.3 (#3440)

- Adjust isolate group creation to allow building with and without shared
  pointer cage
- Update V8 defines in compile_flags.txt based on bazel aquery output –
  we currently build V8 without perfetto support. Ideally we'd have an
  external, auto-generated file with the set of definitions that matter for
  embedders, but for now this needs to be maintained manually.
- Fix some of the deprecation warnings from V8 13.3.
- Change comment on updating Chromium zlib, this is more of a chore than a
  necessity.

* Fix V8 macOS build

---------

Co-authored-by: Felix Hanau <felix@cloudflare.com>

Author: erikcorry

WORKSPACE

@@ -126,7 +126,7 @@ filegroup(
 #
 git_repository(
     name = "com_google_absl",
-    commit = "dc257ad54f38739767a6cb26eb57fd51c37bfe3c",
+    commit = "72093794ac42be8105817ae0b0569fb411a6ca9b",
     remote = "https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git",
 )
 
@@ -144,6 +144,18 @@ git_repository(
     remote = "https://chromium.googlesource.com/external/github.com/Maratyszcza/FP16.git",
 )
 
+git_repository(
+    name = "highway",
+    commit = "00fe003dac355b979f36157f9407c7c46448958e",
+    remote = "https://chromium.googlesource.com/external/github.com/google/highway.git",
+)
+
+# Bindings for Highway library used by V8
+bind(
+    name = "hwy",
+    actual = "@highway//:hwy",
+)
+
 # Bindings for abseil libraries used by V8
 [
     bind(
@@ -157,11 +169,6 @@ git_repository(
     ]
 ]
 
-bind(
-    name = "absl_optional",
-    actual = "@com_google_absl//absl/types:optional",
-)
-
 # OK, now we can bring in tcmalloc itself.
 http_archive(
     name = "com_google_tcmalloc",
@@ -178,8 +185,10 @@ http_archive(
 git_repository(
     name = "zlib",
     build_file = "//:build/BUILD.zlib",
-    # Must match the version used by v8
-    commit = "fa9f14143c7938e6a1d18443900efee7a1e5e669",
+    # This should match the version specified in V8 DEPS, but in practice it is generally acceptable
+    # for it to be behind – zlib is very stable and its API has not changed in a long time, most
+    # changes to the Chromium fork affect ancillary tools and not the zlib library itself.
+    commit = "82a5fecf8aae8f288267cfdb2d29c9ebf7b37e59",
     remote = "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
 )
 

build/deps/v8.bzl

@@ -1,9 +1,9 @@
 load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-VERSION = "13.2.152.34"
+VERSION = "13.3.415.18"
 
-INTEGRITY = "sha256-wER1sDu6Ez7pXzLDufpxYE26d3S1WdsyuQxoFvzLc5Q="
+INTEGRITY = "sha256-irTC8837o+iRvTVx6YatlscLn3+nJcr5RumtHCMUhW0="
 
 PATCHES = [
     "0001-Allow-manually-setting-ValueDeserializer-format-vers.patch",
@@ -23,11 +23,11 @@ PATCHES = [
     "0015-Update-illegal-invocation-error-message-in-v8.patch",
     "0016-Implement-cross-request-context-promise-resolve-hand.patch",
     "0017-Modify-where-to-look-for-fast_float-dependency.patch",
-    "0018-Return-rejected-promise-from-WebAssembly.compile-if-.patch",
-    "0019-Add-another-slot-in-the-isolate-for-embedder.patch",
-    "0020-Add-ValueSerializer-SetTreatProxiesAsHostObjects.patch",
-    "0021-Disable-memory-leak-assert-when-shutting-down-V8.patch",
-    "0022-Enable-V8-shared-linkage.patch",
+    "0018-Add-another-slot-in-the-isolate-for-embedder.patch",
+    "0019-Add-ValueSerializer-SetTreatProxiesAsHostObjects.patch",
+    "0020-Disable-memory-leak-assert-when-shutting-down-V8.patch",
+    "0021-Enable-V8-shared-linkage.patch",
+    "0022-Fix-macOS-build.patch",
 ]
 
 # V8 and its dependencies
@@ -56,7 +56,7 @@ def deps_v8():
     git_repository(
         name = "com_googlesource_chromium_icu",
         build_file = "@v8//:bazel/BUILD.icu",
-        commit = "4239b1559d11d4fa66c100543eda4161e060311e",
+        commit = "bbccc2f6efc1b825de5f2c903c48be685cd0cf22",
         patch_cmds = ["find source -name BUILD.bazel | xargs rm"],
         patch_cmds_win = ["Get-ChildItem -Path source -File -Include BUILD.bazel -Recurse | Remove-Item"],
         remote = "https://chromium.googlesource.com/chromium/deps/icu.git",

compile_flags.txt

@@ -89,6 +89,8 @@
 -DV8_ENABLE_CHECKS
 -DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA
 -DV8_ENABLE_LAZY_SOURCE_POSITIONS
+-DV8_ENABLE_MAGLEV
+-DV8_ENABLE_SPARKPLUG
 -DV8_ENABLE_TURBOFAN
 -DV8_ENABLE_WEBASSEMBLY
 -DV8_HAVE_TARGET_OS
@@ -97,7 +99,6 @@
 -DV8_TARGET_ARCH_X64
 -DV8_TARGET_OS_LINUX
 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64
--DV8_USE_PERFETTO
 -DWORKERD_USE_PERFETTO
 -DPERFETTO_ENABLE_LEGACY_TRACE_EVENTS=1
 -DWORKERD_ICU_DATA_EMBED

patches/v8/0001-Allow-manually-setting-ValueDeserializer-format-vers.patch

@@ -1,4 +1,4 @@
-From 38b8fe7083c7b168204f0225040403a5a5887524 Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Alex Robinson <arobinson@cloudflare.com>
 Date: Wed, 2 Mar 2022 15:58:04 -0600
 Subject: Allow manually setting ValueDeserializer format version
@@ -35,10 +35,10 @@ index 0cb3e045bc46ec732956318b980e749d1847d06d..40ad805c7970cc9379e69f046205836d
     * Reads raw data in various common formats to the buffer.
     * Note that integer types are read in base-128 varint format, not with a
 diff --git a/src/api/api.cc b/src/api/api.cc
-index 3e15759b3d30ff0ac8c311fa409b34d19ba7ae2c..88b9002375fba64bd6b4aa41eaaccce25a861b23 100644
+index c0ff2001df718c89bd1fdf06e95d51e56aa23f03..c9d69132f41457d6eb1f2996dea30fdbba8143f9 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3626,6 +3626,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
+@@ -3646,6 +3646,10 @@ uint32_t ValueDeserializer::GetWireFormatVersion() const {
    return private_->deserializer.GetWireFormatVersion();
  }
 
@@ -48,12 +48,12 @@ index 3e15759b3d30ff0ac8c311fa409b34d19ba7ae2c..88b9002375fba64bd6b4aa41eaaccce2
 +
  MaybeLocal<Value> ValueDeserializer::ReadValue(Local<Context> context) {
    PREPARE_FOR_EXECUTION(context, ValueDeserializer, ReadValue);
-   i::MaybeHandle<i::Object> result;
+   i::MaybeDirectHandle<i::Object> result;
 diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
-index 342c58be184d098499b04e656a4b7729e6953d3d..fd9ff05f3f5455a84b76246b5e9996cf7bcbf8db 100644
+index 3e76d677a1753eef605b87a203fcbde0b788bc49..c58a695378ea692d9cebef4b04ea86202baba49d 100644
 --- a/src/objects/value-serializer.h
 +++ b/src/objects/value-serializer.h
-@@ -218,6 +218,13 @@ class ValueDeserializer {
+@@ -220,6 +220,13 @@ class ValueDeserializer {
     */
    uint32_t GetWireFormatVersion() const { return version_; }
 

patches/v8/0002-Allow-manually-setting-ValueSerializer-format-versio.patch

@@ -1,4 +1,4 @@
-From a5f845b13014fddc6f6f108b7b466159b06229d2 Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: James M Snell <jasnell@gmail.com>
 Date: Wed, 16 Mar 2022 08:59:21 -0700
 Subject: Allow manually setting ValueSerializer format version
@@ -22,10 +22,10 @@ index 40ad805c7970cc9379e69f046205836dbd760373..596be18adeb3a5a81794aaa44b1d347d
     * Writes out a header, which includes the format version.
     */
 diff --git a/src/api/api.cc b/src/api/api.cc
-index 88b9002375fba64bd6b4aa41eaaccce25a861b23..2e2dcb6a26d61bddd23a783fc50d2f22b2ed4070 100644
+index c9d69132f41457d6eb1f2996dea30fdbba8143f9..1cb6383aa42545433f07e88e0a21a2bc73d44348 100644
 --- a/src/api/api.cc
 +++ b/src/api/api.cc
-@@ -3494,6 +3494,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
+@@ -3514,6 +3514,10 @@ ValueSerializer::ValueSerializer(Isolate* v8_isolate, Delegate* delegate)
 
  ValueSerializer::~ValueSerializer() { delete private_; }
 
@@ -37,7 +37,7 @@ index 88b9002375fba64bd6b4aa41eaaccce25a861b23..2e2dcb6a26d61bddd23a783fc50d2f22
 
  void ValueSerializer::SetTreatArrayBufferViewsAsHostObjects(bool mode) {
 diff --git a/src/objects/value-serializer.cc b/src/objects/value-serializer.cc
-index fbd616fbf6f7678279a8ead4fd91e7b9bae3fc5d..7683d5e8e802503ff76ded13b2dfdba44e8fbdaa 100644
+index 8b116abf485630de0a80b72ab71c22490a51bc31..0034b0d9807d19836a0d00247a98b63ec36b7614 100644
 --- a/src/objects/value-serializer.cc
 +++ b/src/objects/value-serializer.cc
 @@ -291,6 +291,7 @@ ValueSerializer::ValueSerializer(Isolate* isolate,
@@ -83,7 +83,7 @@ index fbd616fbf6f7678279a8ead4fd91e7b9bae3fc5d..7683d5e8e802503ff76ded13b2dfdba4
  }
 
 diff --git a/src/objects/value-serializer.h b/src/objects/value-serializer.h
-index fd9ff05f3f5455a84b76246b5e9996cf7bcbf8db..cb9f1f3d9750da8914d5bd73c6742d6459c48e06 100644
+index c58a695378ea692d9cebef4b04ea86202baba49d..76722020fd33d720e1504a3f811f8b4bef7d80ea 100644
 --- a/src/objects/value-serializer.h
 +++ b/src/objects/value-serializer.h
 @@ -54,6 +54,11 @@ class ValueSerializer {
@@ -98,7 +98,7 @@ index fd9ff05f3f5455a84b76246b5e9996cf7bcbf8db..cb9f1f3d9750da8914d5bd73c6742d64
    /*
     * Writes out a header, which includes the format version.
     */
-@@ -179,6 +184,7 @@ class ValueSerializer {
+@@ -181,6 +186,7 @@ class ValueSerializer {
    bool treat_array_buffer_views_as_host_objects_ = false;
    bool out_of_memory_ = false;
    Zone zone_;

patches/v8/0003-Allow-Windows-builds-under-Bazel.patch

@@ -1,46 +1,46 @@
-From 3f722017889ee5ca565a41ff57954ef3a52b90eb Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Brendan Coll <bcoll@cloudflare.com>
 Date: Thu, 16 Mar 2023 11:56:10 +0000
 Subject: Allow Windows builds under Bazel
 
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 6c19fa58f66ea0e680be6881cd4f402f4c7bef93..13e4bc0c80f23907cf07a7d338a6bd4398e413ca 100644
+index 6467518686d6e886c4f3a7f787551bc3be914462..c056e87386233c7d8e512dfa53f4108c8b42678e 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
-@@ -829,6 +829,7 @@ filegroup(
+@@ -822,6 +822,7 @@ filegroup(
          "src/base/platform/mutex.h",
          "src/base/platform/platform.cc",
          "src/base/platform/platform.h",
 +        "src/base/platform/platform-posix.h",  # Always included by src/execution/isolate.h
          "src/base/platform/semaphore.cc",
          "src/base/platform/semaphore.h",
          "src/base/platform/time.cc",
-@@ -872,7 +873,6 @@ filegroup(
+@@ -866,7 +867,6 @@ filegroup(
      ] + select({
          "@v8//bazel/config:is_posix": [
              "src/base/platform/platform-posix.cc",
 -            "src/base/platform/platform-posix.h",
              "src/base/platform/platform-posix-time.cc",
              "src/base/platform/platform-posix-time.h",
          ],
-@@ -895,6 +895,7 @@ filegroup(
+@@ -889,6 +889,7 @@ filegroup(
          "@v8//bazel/config:is_windows": [
              "src/base/debug/stack_trace_win.cc",
              "src/base/platform/platform-win32.cc",
 +            "src/base/platform/platform-win32.h",
              "src/base/win32-headers.h",
          ],
      }),
-@@ -1277,6 +1278,7 @@ filegroup(
+@@ -1271,6 +1272,7 @@ filegroup(
          "include/v8-wasm-trap-handler-posix.h",
          "src/api/api.cc",
          "src/api/api.h",
 +        "include/v8-wasm-trap-handler-win.h",
          "src/api/api-arguments.cc",
          "src/api/api-arguments.h",
          "src/api/api-arguments-inl.h",
-@@ -2762,6 +2764,11 @@ filegroup(
+@@ -2757,6 +2759,11 @@ filegroup(
              "src/trap-handler/handler-inside-posix.cc",
              "src/trap-handler/handler-outside-posix.cc",
          ],
@@ -52,7 +52,7 @@ index 6c19fa58f66ea0e680be6881cd4f402f4c7bef93..13e4bc0c80f23907cf07a7d338a6bd43
          "//conditions:default": [],
      }) + select({
          "@v8//bazel/config:v8_arm64_simulator": [
-@@ -2769,13 +2776,6 @@ filegroup(
+@@ -2764,13 +2771,6 @@ filegroup(
              "src/trap-handler/trap-handler-simulator.h",
          ],
          "//conditions:default": [],
@@ -66,7 +66,7 @@ index 6c19fa58f66ea0e680be6881cd4f402f4c7bef93..13e4bc0c80f23907cf07a7d338a6bd43
      }) + select({
          "@v8//bazel/config:is_windows_64bit": [
              "src/diagnostics/unwinding-info-win64.cc",
-@@ -3836,6 +3836,9 @@ filegroup(
+@@ -3833,6 +3833,9 @@ filegroup(
          "@v8//bazel/config:is_msvc_asm_ia32": ["src/heap/base/asm/ia32/push_registers_masm.asm"],
          "@v8//bazel/config:is_msvc_asm_x64": ["src/heap/base/asm/x64/push_registers_masm.asm"],
          "@v8//bazel/config:is_msvc_asm_arm64": ["src/heap/base/asm/arm64/push_registers_masm.S"],
@@ -76,7 +76,7 @@ index 6c19fa58f66ea0e680be6881cd4f402f4c7bef93..13e4bc0c80f23907cf07a7d338a6bd43
      }),
  )
 
-@@ -4232,9 +4235,11 @@ filegroup(
+@@ -4227,9 +4230,11 @@ filegroup(
          "src/d8/d8-js.cc",
          "src/d8/d8-platforms.cc",
          "src/d8/d8-platforms.h",
@@ -90,7 +90,7 @@ index 6c19fa58f66ea0e680be6881cd4f402f4c7bef93..13e4bc0c80f23907cf07a7d338a6bd43
  )
 
  genrule(
-@@ -4585,7 +4590,7 @@ py_test(
+@@ -4581,7 +4586,7 @@ py_test(
          ":noicu/d8",
          ":noicu/v8_build_config",
          "//testing/pybase",
@@ -99,7 +99,7 @@ index 6c19fa58f66ea0e680be6881cd4f402f4c7bef93..13e4bc0c80f23907cf07a7d338a6bd43
      main = "tools/run-tests.py",
      python_version = "PY3",
      tags = [
-@@ -4624,7 +4629,7 @@ py_test(
+@@ -4620,7 +4625,7 @@ py_test(
          ":icu/d8",
          ":icu/v8_build_config",
          "//testing/pybase",

patches/v8/0004-Disable-bazel-whole-archive-build.patch

@@ -1,4 +1,4 @@
-From 23f8db09c4d8ac24637d0f9d190c8247f67415ed Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Felix Hanau <felix@cloudflare.com>
 Date: Tue, 11 Apr 2023 14:41:31 -0400
 Subject: Disable bazel whole-archive build

patches/v8/0005-Speed-up-V8-bazel-build-by-always-using-target-cfg.patch

@@ -1,4 +1,4 @@
-From b44a9a7a78ddfe2d29b96b05ea9ed3c3638088bd Mon Sep 17 00:00:00 2001
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
 From: Felix Hanau <felix@cloudflare.com>
 Date: Wed, 7 Jun 2023 21:40:54 -0400
 Subject: Speed up V8 bazel build by always using target cfg
@@ -12,7 +12,7 @@ generated files as the output set. While unrelated to the build cfg change,
 this also improves build times.
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 13e4bc0c80f23907cf07a7d338a6bd4398e413ca..f62048d985496583457ef370bea74c761524bf3a 100644
+index c056e87386233c7d8e512dfa53f4108c8b42678e..69d5e5206ccae77199b9df7efe7797264b42a6e7 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
 @@ -17,6 +17,7 @@ load(
@@ -23,7 +23,7 @@ index 13e4bc0c80f23907cf07a7d338a6bd4398e413ca..f62048d985496583457ef370bea74c76
  )
  load(":bazel/v8-non-pointer-compression.bzl", "v8_binary_non_pointer_compression")
 
-@@ -4242,22 +4243,20 @@ filegroup(
+@@ -4237,22 +4238,20 @@ filegroup(
      }),
  )
 
@@ -52,7 +52,7 @@ index 13e4bc0c80f23907cf07a7d338a6bd4398e413ca..f62048d985496583457ef370bea74c76
  )
 
  v8_mksnapshot(
-@@ -4458,8 +4457,6 @@ v8_binary(
+@@ -4454,8 +4453,6 @@ v8_binary(
      srcs = [
          "src/regexp/gen-regexp-special-case.cc",
          "src/regexp/special-case.h",
@@ -61,7 +61,7 @@ index 13e4bc0c80f23907cf07a7d338a6bd4398e413ca..f62048d985496583457ef370bea74c76
      ],
      copts = ["-Wno-implicit-fallthrough"],
      defines = [
-@@ -4471,6 +4468,7 @@ v8_binary(
+@@ -4467,6 +4464,7 @@ v8_binary(
      ],
      deps = [
          "//external:absl_optional",