Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpt: Include all files in archive #5

Merged
merged 1 commit into from
Mar 5, 2025
Merged

wpt: Include all files in archive #5

merged 1 commit into from
Mar 5, 2025

Conversation

npaun
Copy link
Member

@npaun npaun commented Mar 5, 2025

Now that we're running the fetch tests, excluding files by type doesn't make sense any more. For example, we need to run the Python backend, use the self-signed certificate, server text files, etc.

@npaun npaun requested a review from anonrig March 5, 2025 16:44
@npaun npaun requested a review from a team as a code owner March 5, 2025 16:44
@npaun npaun requested a review from ObsidianMinor March 5, 2025 16:44
@fhanau
Copy link

fhanau commented Mar 5, 2025

Are we still filtering by directory? As discussed before the size of wpt tests alone can slow down bazel's startup, especially on Windows. (Happy with specifying a wider set of directories than we currently use in tests, but realistically we won't need to implement all the APIs there are tests for)

@npaun
Copy link
Member Author

npaun commented Mar 5, 2025

@fhanau No I had only the file type filtering previously. I'll add a list of directories now that we don't have it.

@npaun npaun force-pushed the npaun/wpt-all-files branch from ddfad20 to ee5d43c Compare March 5, 2025 17:00
@npaun npaun requested a review from fhanau March 5, 2025 17:01
Now that we're running the fetch tests, excluding files by type doesn't make sense any more. For example, we need to run the Python backend, use the self-signed certificate, server text files, etc.
@npaun npaun force-pushed the npaun/wpt-all-files branch from ee5d43c to 46d2447 Compare March 5, 2025 17:33
@npaun npaun merged commit b1026e1 into main Mar 5, 2025
@npaun npaun deleted the npaun/wpt-all-files branch March 5, 2025 17:33
npaun added a commit that referenced this pull request Mar 7, 2025
@fhanau observed that the exclude list in #5 wasn't working properly. I've tried it out on a Linux machine, and am pretty sure this version should work
npaun added a commit that referenced this pull request Mar 7, 2025
@fhanau observed that the exclude list in #5 wasn't working properly. I've tried it out on a Linux machine, and am pretty sure this version should work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants