Update to eslint v9 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibmeu
reviewed
Sep 30, 2024
| @@ -56,7 +58,7 @@ async function mockImportKey( | |||
| crypto.subtle.importKey = parentImportKey; | |||
| try { | |||
| if (format === 'jwk') { | |||
| return crypto.subtle.importKey( | |||
| return await crypto.subtle.importKey( | |||
There was a problem hiding this comment.
what is the reason to await instead of returning a promise that would be awaited?
There was a problem hiding this comment.
From the linter rule docs:
When the return statement is in try...catch, awaiting the promise also allows the promise's rejection to be caught instead of leaving the error to the caller.
armfazh
force-pushed
the
UpdateEslintV9
branch
from
740a7ea to
c0e70de
Compare
thibmeu
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: