-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui-storagebrowser] fixes file preview for non-readable file #4061
base: master
Are you sure you want to change the base?
Conversation
|
Backend Code Coverage Report •
Pytest Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
mockData = { | ||
isContentReadable: false, | ||
contents: '' | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could potentially change the outcome of other tests relying on mockData. Perhaps resetting it in an "beforeEach"..
✅ Test files were modified. Ensure that the tests cover all relevant changes |
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.