Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database migrations in CI #4354

Closed
apburnes opened this issue Jan 10, 2024 · 1 comment · Fixed by #4355
Closed

Fix database migrations in CI #4354

apburnes opened this issue Jan 10, 2024 · 1 comment · Fixed by #4355
Labels
squad-pages

Comments

@apburnes
Copy link
Contributor

apburnes commented Jan 10, 2024 •
edited
Loading

Make sure database migrations run in CI Task and not via CF task so errors in db migrations are instantly flagged and notified. Update db migrations to SSL with pg 15 upgrade.

Acceptance Criteria

  • Recreate CI task to run migrations in CI task container and not a CF task
  • Add ssl=true to db config
apburnes added a commit that referenced this issue Jan 10, 2024
@apburnes
fix(ci): Run db migrations in CI task container with SSL #4354
5ad4986
@apburnes apburnes mentioned this issue Jan 10, 2024
Merged
@svenaas
Copy link
Contributor

svenaas commented Jan 10, 2024

This will allow #4352 verification to proceed in dev.

apburnes added a commit that referenced this issue Jan 10, 2024
@apburnes
fix(ci): Run db migrations in CI task container with SSL #4354
3973006
apburnes added a commit that referenced this issue Jan 11, 2024
@apburnes
fix(ci): Run db migrations in CI task container with SSL #4354
5293be4
apburnes added a commit that referenced this issue Jan 11, 2024
@apburnes
Merge pull request #4355 from cloud-gov/fix-ci-rework-db-migrations-task
ad7e780 
fix(ci): Run db migrations in CI task container with SSL #4354
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
squad-pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ci): Run db migrations in CI task container with SSL #4354 cloud-gov/pages-core
2 participants
@svenaas @apburnes