Custom URL generator #46

riyajain59 · 2022-03-26T22:37:37Z

Status:

🚀 Ready

Description

Generate a custom URL that saves settings of the clock. The settings include the language, whether the ticker shows up, and the different lifelines.

Fixes #17

Todos

Combine all settings into one JSON object
Call stringify on object
Use lz-string to compress the data for the URL
Decompress the string to convert the data back to show up on the URL

Deadline (from the issue)

Screenshots

into url-generator

vercel · 2022-03-26T22:37:41Z

@riyajain59 is attempting to deploy a commit to a Personal Account on Vercel that is not owned by them.

In order for the commit to be deployed, @riyajain59 must be granted access to the connected Vercel project.

If you're the owner of the Personal Account, transfer the project to a Vercel Team and start collaborating, or learn more.

into url-generator

vercel · 2022-04-09T22:20:11Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

climate-clock – ./

🔍 Inspect: https://vercel.com/hack4impact/climate-clock/HYrttUudBPTup4PvkPG1AfiXnWSq
✅ Preview: https://climate-clock-git-url-generator-hack4impact1.vercel.app

into url-generator

vercel · 2022-04-19T21:07:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
climate-clock	✅ Ready (Inspect)	Visit Preview	Jun 26, 2022 at 5:10AM (UTC)

eeshabarua

Yayyy this looks awesome Riya!! Just a couple small things and you're golden.

eeshabarua · 2022-04-27T17:20:48Z

client/src/App.tsx

@@ -1,6 +1,7 @@
 import { useState } from 'react'
 import { WindowSize } from '@reach/window-size'
 import { ThemeProvider } from 'styled-components'
+// import { get } from './api/config'


Is this comment necessary?

eeshabarua · 2022-04-27T17:21:55Z

client/src/App.tsx

  return (
    <ThemeProvider theme={theme}>
      <FullScreen
        handle={handle}
        onChange={() => setFullscreenButton(!showFullscreenButton)}
      >
+        {' '}


also the space, i just may not be familiar with the syntax though

This gets added by the linter sometimes but it should be removed

eeshabarua · 2022-04-27T17:22:50Z

client/src/pages/Home.tsx

@@ -15,7 +17,8 @@ export default function Home() {
  )
  const [newsfeedModules, setNewsfeedModules] = useState<NewsInterface[]>([])
  const [errorFlag, setErrorFlag] = useState<boolean>(false)
-
+  const navigate = useNavigate()
+  //localStorage.getItem(LANGUAGE_LOCAL_STORAGE_KEY),localStorage.getItem(LIFELINES_LOCAL_STORAGE_KEY)


is this comment necessary?

daniel-moon32

Code looks good but, it looks like your changes break the website currently (check the vercel deployment to see what I'm referring to). It seem like not adding the url at the end will null is breaking the code.

daniel-moon32 · 2022-04-27T20:05:58Z

client/src/App.tsx

  return (
    <ThemeProvider theme={theme}>
      <FullScreen
        handle={handle}
        onChange={() => setFullscreenButton(!showFullscreenButton)}
      >
+        {' '}


This gets added by the linter sometimes but it should be removed

daniel-moon32 · 2022-04-27T20:06:42Z

client/src/components/settings/LifelineCreationForm.tsx

@@ -52,6 +60,18 @@ const LifelineCreationForm = () => {
   */
  const formSubmit = (e: any) => {


I would recommend against using the any type since it is both bad practice and the linter will complain about this in the future

daniel-moon32 · 2022-05-01T08:36:41Z

Bugs:

Replaces entire url instead of just slug whenever redirecting to other pages
decompressing does not work from slug
compression works to slug

…limate-clock-widget into url-generator

netlify · 2022-08-14T23:23:58Z

❌ Deploy Preview for stunning-cocada-f3d6ad failed.

Name	Link
🔨 Latest commit	`09d6957`
🔍 Latest deploy log	https://app.netlify.com/sites/stunning-cocada-f3d6ad/deploys/62f98405a446cf00081b935b

riyajain59 added 2 commits March 26, 2022 16:59

Draft PR

fcd1d0b

Merge branch 'main' of https://github.com/hack4impact-uiuc/climate-clock

f74840d

into url-generator

riyajain59 added 2 commits April 2, 2022 17:21

Broken URL generator

0a6b759

Merge branch 'main' of https://github.com/hack4impact-uiuc/climate-clock

1f6544c

into url-generator

vercel bot deployed to Preview – climate-clock April 9, 2022 22:20 View deployment

Implement localStorage of URL generator

9339620

vercel bot deployed to Preview – climate-clock April 9, 2022 22:21 View deployment

Implement URL generator

9c6723f

vercel bot deployed to Preview – climate-clock April 13, 2022 00:09 View deployment

riyajain59 changed the title ~~Draft PR~~ Custom URL generator Apr 13, 2022

riyajain59 marked this pull request as ready for review April 13, 2022 00:10

Merge branch 'main' of https://github.com/hack4impact-uiuc/climate-clock

80d14e6

into url-generator

vercel bot deployed to Preview – climate-clock April 13, 2022 01:03 View deployment

Half-working url generator

4db64d7

vercel bot had a problem deploying to Preview – climate-clock April 19, 2022 21:10 Failure

riyajain59 added 2 commits April 21, 2022 22:08

Update URL path and decompress URL for new settings

0994506

Add URL code for lifeline settings

241d700

vercel bot deployed to Preview – climate-clock April 26, 2022 21:23 View deployment

riyajain59 requested review from daniel-moon32, AaronAlexander-debug and eeshabarua and removed request for AaronAlexander-debug April 26, 2022 21:45

Fix URL history

e5a0ce0

vercel bot deployed to Preview – climate-clock April 27, 2022 01:02 View deployment

Default URL showing up

ec4ec28

vercel bot had a problem deploying to Preview – climate-clock April 27, 2022 01:10 Failure

Fix build

1fd3832

vercel bot deployed to Preview – climate-clock April 27, 2022 01:25 View deployment

eeshabarua suggested changes Apr 27, 2022

View reviewed changes

daniel-moon32 requested changes Apr 27, 2022

View reviewed changes

Fix API error

2cf8dbc

vercel bot deployed to Preview – climate-clock May 1, 2022 03:18 View deployment

Broken check for null compressed value

580213d

vercel bot deployed to Preview – climate-clock May 1, 2022 03:22 View deployment

Fix null value not showing up

e22f66f

vercel bot deployed to Preview – climate-clock May 1, 2022 06:56 View deployment

merge from main

e13e90b

vercel bot had a problem deploying to Preview – climate-clock May 1, 2022 08:21 Failure

fix navbar

d7e2799

vercel bot deployed to Preview – climate-clock May 1, 2022 18:32 View deployment

riyajain59 added 2 commits June 21, 2022 23:38

Fix updating url for language settings

6338945

Broken lifeline URL sharing

9466479

vercel bot deployed to Preview – climate-clock June 24, 2022 20:47 View deployment

fix type mismatch

93b02e5

vercel bot deployed to Preview – climate-clock June 26, 2022 05:09 View deployment

Merge branch 'main' of https://github.com/BeautifulTrouble/h4i-uiuc-c…

09d6957

…limate-clock-widget into url-generator

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom URL generator #46

Custom URL generator #46

riyajain59 commented Mar 26, 2022 •

edited

Loading

vercel bot commented Mar 26, 2022

vercel bot commented Apr 9, 2022 •

edited

Loading

vercel bot commented Apr 19, 2022 •

edited

Loading

eeshabarua left a comment •

edited

Loading

eeshabarua Apr 27, 2022

eeshabarua Apr 27, 2022

daniel-moon32 Apr 27, 2022

eeshabarua Apr 27, 2022

daniel-moon32 left a comment

daniel-moon32 Apr 27, 2022

daniel-moon32 Apr 27, 2022

daniel-moon32 commented May 1, 2022

netlify bot commented Aug 14, 2022 •

edited

Loading

		@@ -52,6 +60,18 @@ const LifelineCreationForm = () => {
		*/
		const formSubmit = (e: any) => {

Custom URL generator #46

Are you sure you want to change the base?

Custom URL generator #46

Conversation

riyajain59 commented Mar 26, 2022 • edited Loading

Status:

Description

Todos

Deadline (from the issue)

Screenshots

vercel bot commented Mar 26, 2022

vercel bot commented Apr 9, 2022 • edited Loading

climate-clock – ./

vercel bot commented Apr 19, 2022 • edited Loading

eeshabarua left a comment • edited Loading

Choose a reason for hiding this comment

eeshabarua Apr 27, 2022

Choose a reason for hiding this comment

eeshabarua Apr 27, 2022

Choose a reason for hiding this comment

daniel-moon32 Apr 27, 2022

Choose a reason for hiding this comment

eeshabarua Apr 27, 2022

Choose a reason for hiding this comment

daniel-moon32 left a comment

Choose a reason for hiding this comment

daniel-moon32 Apr 27, 2022

Choose a reason for hiding this comment

daniel-moon32 Apr 27, 2022

Choose a reason for hiding this comment

daniel-moon32 commented May 1, 2022

netlify bot commented Aug 14, 2022 • edited Loading

❌ Deploy Preview for stunning-cocada-f3d6ad failed.

riyajain59 commented Mar 26, 2022 •

edited

Loading

vercel bot commented Apr 9, 2022 •

edited

Loading

vercel bot commented Apr 19, 2022 •

edited

Loading

eeshabarua left a comment •

edited

Loading

netlify bot commented Aug 14, 2022 •

edited

Loading