Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decoupled authentication guide #29

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Decoupled authentication guide #29

merged 14 commits into from
Oct 9, 2024

Conversation

Lassejoe
Copy link
Contributor

@Lassejoe Lassejoe requested a review from a team June 26, 2024 13:38
@mt-clearhaus mt-clearhaus changed the title Decouple authentication guide Decoupled authentication guide Jun 26, 2024
thejspr
thejspr approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@thejspr thejspr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few minor suggestions

@Lassejoe @thejspr
Apply suggestions from code review
2ddad26 
Co-authored-by: Jesper Kjeldgaard <jk@clearhaus.com>
cbobach
cbobach requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@cbobach cbobach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry that I can't come up with anything better myself. But think we still need to work a bit on the current suggestion.

source/decoupled_authentication.rst Outdated Show resolved Hide resolved
@Lassejoe Lassejoe requested a review from cbobach July 2, 2024 06:27
cbobach
cbobach reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@cbobach cbobach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

source/decoupled_authentication.rst Outdated Show resolved Hide resolved
source/decoupled_authentication.rst Outdated Show resolved Hide resolved
source/decoupled_authentication.rst Outdated Show resolved Hide resolved
source/guides.rst Show resolved Hide resolved
@Lassejoe @cbobach
Apply suggestions from code review
9ca8bc4 
Co-authored-by: Christian Bobach <christian.bobach@gmail.com>
Lassejoe and others added 3 commits July 3, 2024 11:04
@Lassejoe @mt-clearhaus
Update source/decoupled_authentication.rst
7f1fb7a 
Co-authored-by: Martin Toft Bay <mt@clearhaus.com>
@Lassejoe @mt-clearhaus
Update source/decoupled_authentication.rst
f5a0789 
Co-authored-by: Martin Toft Bay <mt@clearhaus.com>
@Lassejoe
Update text suggested by @mt-clearhaus
7b5cd15
mt-clearhaus
mt-clearhaus approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🏆

mt-clearhaus
mt-clearhaus reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@mt-clearhaus mt-clearhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

source/decoupled_authentication.rst Outdated Show resolved Hide resolved
source/decoupled_authentication.rst Outdated Show resolved Hide resolved
source/decoupled_authentication.rst Outdated Show resolved Hide resolved
source/decoupled_authentication.rst Outdated Show resolved Hide resolved
Lassejoe and others added 2 commits October 9, 2024 13:31
@Lassejoe @mt-clearhaus
Apply suggestions from code review
e9f4338 
Co-authored-by: Martin Toft Bay <mt@clearhaus.com>
@Lassejoe
Update live.py.
ca01b53
@Lassejoe Lassejoe merged commit 8fca3af into master Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt-clearhaus mt-clearhaus mt-clearhaus approved these changes

@thejspr thejspr Awaiting requested review from thejspr

@cbobach cbobach Awaiting requested review from cbobach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lassejoe @thejspr @cbobach @mt-clearhaus