Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group Name field #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

stenvdb
Copy link
Contributor

@stenvdb stenvdb commented Feb 3, 2021

For a project we use, we needed the ability to update the group name in Campaign Monitor so we can better filter out some emails. I've updated the adapter for the optional extra field. It fallbacks to the default name (which was just 'Craft CMS').

@heymarkreeves
Copy link
Member

Hi, @stenvdb!

Any chance you've tested what happens if you update the plugin but have not yet re-saved its settings with the Group Name value set? I see where there's a fallback value here, but not here:

$groupName = Craft::parseEnv($this->groupName);

I'm just wondering what happens if someone updates the plugin without re-saving its settings to set that value. I'll need to test that.

Thanks!

@stenvdb
Copy link
Contributor Author

stenvdb commented Feb 3, 2021

Good catch, it did not work 🙈 I've added a better conditional and removed the argument type since it can be null if the settings haven't been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants