Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use non-blocking I/O for all network requests #5

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Use non-blocking I/O for all network requests #5

merged 3 commits into from
Oct 28, 2024

Conversation

claui
Copy link
Owner

@claui claui commented Oct 28, 2024

  • Convert all interfaces to async
  • Add example code to documentation
  • Replace requests w/ httpx so I/O no longer blocks

claui added 2 commits October 28, 2024 21:35
@claui
Convert all interfaces to async
997d737 
As a first step towards making the library use non-blocking I/O, convert
all network-facing interfaces and their call sites to async.

Note that the network request itself is still blocking. A subsequent
commit will replace the `requests` library with one that supports
non-blocking I/O.
@claui
Add example code to documentation
1907097
@claui claui added the enhancement New feature or request label Oct 28, 2024
@claui claui merged commit ec38bd9 into main Oct 28, 2024
1 check passed
@claui claui deleted the httpx branch October 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@claui