Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kube-apiserver extra args override #415

Merged
merged 3 commits into from
Mar 4, 2024
Merged

fix: kube-apiserver extra args override #415

merged 3 commits into from
Mar 4, 2024

Conversation

jwitko
Copy link
Contributor

@jwitko jwitko commented Feb 16, 2024

Fixes #414

@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit ada9a98
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/65e49c566a0a0b00081f07bb

prometherion
prometherion requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, may I ask you to commit the changes generated by make yaml-installation-file?

@jwitko jwitko force-pushed the 414-Allow-kubeApiServer-extraArgs-override branch from 515acc7 to cee6cba Compare February 26, 2024 22:30
@jwitko jwitko requested a review from prometherion February 26, 2024 22:31
@jwitko
Copy link
Contributor Author

jwitko commented Feb 26, 2024

Please, may I ask you to commit the changes generated by make yaml-installation-file?

Should be done now.

@prometherion prometherion added this to the v0.4.2 milestone Feb 27, 2024
@jwitko jwitko force-pushed the 414-Allow-kubeApiServer-extraArgs-override branch from 9181a7e to ada9a98 Compare March 3, 2024 15:50
@jwitko
Copy link
Contributor Author

jwitko commented Mar 3, 2024

Ran gofumpt to pass CI / lint check.

@prometherion prometherion removed this from the v0.4.2 milestone Mar 4, 2024
@prometherion prometherion merged commit 7ac8e5e into clastix:master Mar 4, 2024
10 checks passed
@jwitko jwitko deleted the 414-Allow-kubeApiServer-extraArgs-override branch March 4, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for overriding kube-apiserver arguments
2 participants
@jwitko @prometherion