Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add conditional logic for datastore #386

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: add conditional logic for datastore #386

merged 3 commits into from
Nov 13, 2023

Conversation

EBMBA
Copy link
Contributor

@EBMBA EBMBA commented Nov 12, 2023

Closes #383

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

✅ Deploy Preview for kamaji-documentation canceled.

Name Link
🔨 Latest commit 7b019a9
🔍 Latest deploy log https://app.netlify.com/sites/kamaji-documentation/deploys/65512d835c30590008bb2307

prometherion
prometherion requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump also the patch version of the Helm Chart, and mark the commit as fix: add conditional logic for datastore rather than feat.

@EBMBA EBMBA changed the title feat: Add conditional logic for datastore fix: Add conditional logic for datastore Nov 12, 2023
@EBMBA EBMBA changed the title fix: Add conditional logic for datastore fix: add conditional logic for datastore Nov 12, 2023
prometherion
prometherion requested changes Nov 12, 2023
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make -C charts/kamaji docs, I forgot this!

@prometherion prometherion merged commit ac06447 into clastix:master Nov 13, 2023
EBMBA added a commit to EBMBA/kamaji that referenced this pull request Nov 19, 2023
@EBMBA
Merge pull request #1 from clastix/master
829371a 
fix: add conditional logic for datastore (clastix#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prometherion prometherion prometherion requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set an existing Datastore Custom Resource when deploying Kamaji
2 participants
@EBMBA @prometherion