[bug] Fixing floating numbers for SQLBindColumns

SQLBindColumn didn't take into consideration the decimal point for some data types Fixes wankdanker#42
clach04 · Oct 27, 2019 · 7835d28 · 7835d28
1 parent d086299
commit 7835d28
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [2.2.2] - 2019-10-27
+### Fixed
+- Fixed SQL_DECIMAL, SQL_REAL, and SQL_NUMERIC losing precision
+
 ## [2.2.1] - 2019-09-13
 ### Fixed
 - pool.query() now closes the connections after query

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "odbc",
   "description": "unixodbc bindings for node",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "homepage": "http://github.com/markdirish/node-odbc/",
   "main": "./lib/odbc.js",
   "repository": {

diff --git a/src/odbc_connection.cpp b/src/odbc_connection.cpp
@@ -1983,7 +1983,7 @@ SQLRETURN ODBCConnection::BindColumns(QueryData *data) {
       case SQL_REAL:
       case SQL_DECIMAL:
       case SQL_NUMERIC:
-        maxColumnLength = (column->ColumnSize + 1) * sizeof(SQLCHAR);
+        maxColumnLength = (column->ColumnSize + 2) * sizeof(SQLCHAR);
         targetType = SQL_C_CHAR;
         break;
 
@@ -1992,6 +1992,7 @@ SQLRETURN ODBCConnection::BindColumns(QueryData *data) {
         maxColumnLength = column->ColumnSize;
         targetType = SQL_C_DOUBLE;
         break;
+
       case SQL_TINYINT:
       case SQL_SMALLINT:
       case SQL_INTEGER: