Merge pull request #9 from 514sid/improve-migration

Add nullOnDelete() for the User-related foreignId column
cjmellor · Aug 24, 2023 · a446e4e · a446e4e
2 parents 38035c7 + d621c69
commit a446e4e
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 6 deletions.
diff --git a/database/migrations/create_ratings_table.php b/database/migrations/create_ratings_table.php
@@ -11,7 +11,7 @@ public function up()
         Schema::create('ratings', function (Blueprint $table) {
             $table->id();
             $table->morphs('rateable');
-            $table->foreignId((string) config(key: 'rating.users.primary_key', default: 'user_id'))->nullable()->constrained();
+            $table->foreignId((string) config(key: 'rating.users.primary_key', default: 'user_id'))->nullable()->constrained()->nullOnDelete();
             $table->integer('rating');
             $table->timestamps();
         });

diff --git a/tests/Concerns/CanBeRatedTest.php b/tests/Concerns/CanBeRatedTest.php
@@ -4,6 +4,7 @@
 use Cjmellor\Rating\Exceptions\MaxRatingException;
 use Cjmellor\Rating\Models\Rating;
 use Cjmellor\Rating\Tests\Models\FakeUser;
+use Illuminate\Support\Facades\DB;
 
 test(description: 'a Model can be rated', closure: function () {
     // Create a Rating and attach to a fake User
@@ -144,3 +145,25 @@
         'rating' => 5,
     ]);
 });
+
+test(description: 'user_id in rating table is set to null when the related user is deleted', closure: function () {
+    $this->actingAs($this->user)->assertAuthenticated();
+
+    $this->secondUser->rate(score: 4);
+
+    $this->assertDatabaseHas(table: Rating::class, data: [
+        'rateable_type' => 'Cjmellor\Rating\Tests\Models\FakeUser',
+        'rateable_id' => $this->secondUser->id,
+        'user_id' => $this->user->id,
+        'rating' => 4,
+    ]);
+
+    DB::table('users')->where('id', $this->user->id)->delete();
+
+    $this->assertDatabaseHas(table: Rating::class, data: [
+        'rateable_type' => 'Cjmellor\Rating\Tests\Models\FakeUser',
+        'rateable_id' => $this->secondUser->id,
+        'user_id' => null,
+        'rating' => 4,
+    ]);
+});
diff --git a/tests/Models/FakeUser.php b/tests/Models/FakeUser.php
@@ -15,4 +15,6 @@ class FakeUser extends User
      * @var bool
      */
     public $timestamps = false;
+
+    protected $table = 'users';
 }
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -15,15 +15,17 @@ public function getEnvironmentSetUp($app): void
     {
         config()->set('database.default', 'testing');
 
-        $migration = include __DIR__.'/../database/migrations/create_ratings_table.php';
-
-        $migration->up();
-
-        Schema::create(table: 'fake_users', callback: function (Blueprint $table) {
+        Schema::create(table: 'users', callback: function (Blueprint $table) {
             $table->id();
             $table->string(column: 'username');
             $table->string(column: 'password');
         });
+
+        Schema::enableForeignKeyConstraints();
+
+        $migration = include __DIR__.'/../database/migrations/create_ratings_table.php';
+
+        $migration->up();
     }
 
     protected function setUp(): void