Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink some boolean types #174

Open
cjcodeproj opened this issue Jan 2, 2025 · 0 comments
Open

Rethink some boolean types #174

cjcodeproj opened this issue Jan 2, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@cjcodeproj
Copy link
Owner

There are a few boolean attributes floating around in the schema which might make more sense if they were set up as enums.

Two examples that come up are this:

 <case slipcover='true'>

and

 <variantTitle sortable='true'>

In both of these cases, it makes more sense to have flexible attribute types that can store one or more different values from a series of choices. Using the above examples, we could have....

 <case features='slipcover'>

and

 <variantTitle traits='sortable'>

The goal of the ticket is to examine some of the booleans in use, and see if it makes more sense to turn them into custom types for situations where we don't want to fall into a trap of multuple true/false values within a single element.

See also: #15

@cjcodeproj cjcodeproj added the enhancement New feature or request label Jan 2, 2025
@cjcodeproj cjcodeproj self-assigned this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant