chore: Fix Camel JBang output file directory auto creation

citrusframework · Jan 20, 2025 · d0c0ad5 · d0c0ad5
1 parent 5c571c8
commit d0c0ad5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/connectors/citrus-jbang-connector/src/main/java/org/citrusframework/jbang/JBangSupport.java b/connectors/citrus-jbang-connector/src/main/java/org/citrusframework/jbang/JBangSupport.java
@@ -432,7 +432,7 @@ private static ProcessAndOutput executeAsync(List<String> command, Path workingD
      */
     private static ProcessAndOutput executeAsync(List<String> command, Path workingDir, File outputFile, Map<String, String> envVars) {
         try {
-            if (!outputFile.getParentFile().mkdirs()) {
+            if (!outputFile.getParentFile().exists() && !outputFile.getParentFile().mkdirs()) {
                 throw new CitrusRuntimeException("Unable to create process output directory: " + outputFile.getParent());
             }
 

diff --git a/endpoints/citrus-camel/src/main/java/org/citrusframework/camel/jbang/CamelJBang.java b/endpoints/citrus-camel/src/main/java/org/citrusframework/camel/jbang/CamelJBang.java
@@ -34,6 +34,7 @@
 import org.citrusframework.exceptions.CitrusRuntimeException;
 import org.citrusframework.jbang.JBangSupport;
 import org.citrusframework.jbang.ProcessAndOutput;
+import org.citrusframework.util.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -49,6 +50,8 @@ public class CamelJBang {
 
     private boolean dumpIntegrationOutput = CamelJBangSettings.isDumpIntegrationOutput();
 
+    private String version;
+
     /**
      * Prevent direct instantiation.
      */
@@ -65,7 +68,10 @@ private CamelJBang() {
             camelApp.trust(url);
         }
 
-        logger.info("Camel JBang version: " + version());
+        String version = version();
+        if (logger.isDebugEnabled()) {
+            logger.debug("Camel JBang version: " + version);
+        }
     }
 
     /**
@@ -145,8 +151,12 @@ public String ps() {
      * Get Camel JBang version.
      */
     public String version() {
-        ProcessAndOutput p = camelApp.run("--version");
-        return p.getOutput();
+        if (!StringUtils.hasText(version)) {
+            ProcessAndOutput p = camelApp.run("--version");
+            version = p.getOutput();
+        }
+
+        return version;
     }
 
     /**