Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui improvements #294

Closed
wants to merge 8 commits into from
Closed

feat: ui improvements #294

wants to merge 8 commits into from

Conversation

MeToCo
Copy link
Contributor

@MeToCo MeToCo commented Aug 19, 2024

  1. made table rows clickable and removed redundant buttons, which are used to consume the click before --> more space for table content
  2. added consistent data-cy test data selectors to html elements to make the ui better testable

@bbortt bbortt self-requested a review August 19, 2024 08:27
Melvin Johner and others added 2 commits August 19, 2024 10:36
@bbortt
Copy link
Collaborator

bbortt commented Aug 19, 2024

thanks @MelvinJohner. because of conflicts I had to rebase and squash it into #295. I've merged the successor.

@bbortt bbortt closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants