Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring and -boot deps #226

Merged
merged 2 commits into from
Jan 17, 2024
Merged

spring and -boot deps #226

merged 2 commits into from
Jan 17, 2024

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Jan 3, 2024 •
edited
Loading

@bbortt bbortt added READY Type: Maintenance Prio: High State: On hold For clarification purposes dependencies Pull requests that update a dependency file java Pull requests that update Java code javascript Pull requests that update Javascript code labels Jan 3, 2024
@bbortt bbortt self-assigned this Jan 3, 2024
@bbortt
Copy link
Collaborator Author

bbortt commented Jan 11, 2024

before merging this, remove this line

citrus-simulator/simulator-spring-boot/src/main/java/org/citrusframework/simulator/service/impl/ScenarioExecutionServiceImpl.java

Line 112 in e2f8b67

logger.warn("Request to complete ScenarioExecution for failed TestCase : {}", testCase, cause);
too. it is rather annoying than useful!

This was referenced Jan 12, 2024
Closed
Closed
Merged
@bbortt
Copy link
Collaborator Author

bbortt commented Jan 15, 2024

should probably also update node (and npm) version to the lts release version, see package.json and pom.xml.

@bbortt bbortt force-pushed the fix/deps branch 2 times, most recently from 3eba535 to 14d95f4 Compare January 17, 2024 21:06
bbortt added 2 commits January 17, 2024 22:14
@bbortt
chore(deps): update @angular/core to v17
20be9a5
@bbortt
chore(deps): update spring-boot
5bc0113 
includes the following dependency updates:
* spring >= 3.1
* spring-boot >= 6.2
@bbortt bbortt removed the State: On hold For clarification purposes label Jan 17, 2024
@bbortt bbortt merged commit b016ebc into citrusframework:main Jan 17, 2024
6 checks passed
@bbortt bbortt deleted the fix/deps branch January 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bbortt bbortt

Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code javascript Pull requests that update Javascript code Prio: High READY Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bbortt