Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

easy response helpers #221

Merged
merged 1 commit into from
Nov 30, 2023
Merged

easy response helpers #221

merged 1 commit into from
Nov 30, 2023

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Nov 24, 2023 •
edited
Loading

we have a lot of these in our code:

        scenario.$(scenario.http()
                .send()
                    .response(HttpStatus.OK)
                    .message()
                    .contentType(MediaType.APPLICATION_JSON_VALUE));
                    .body(myJsonObject)

the following would help for sure:

        scenario.$(
            scenario.http()
                .sendOkJson(myJsonObject)
        );

more to come in the future, maybe...

@bbortt bbortt self-assigned this Nov 24, 2023
@bbortt bbortt requested a review from tschlat November 24, 2023 10:29
@bbortt bbortt force-pushed the feature/easy-response-helpers branch from ff3398a to a4a574b Compare November 24, 2023 10:51
@bbortt bbortt force-pushed the feature/easy-response-helpers branch from a4a574b to c3cfabb Compare November 30, 2023 12:17
@bbortt bbortt merged commit c204d66 into citrusframework:main Nov 30, 2023
6 checks passed
@bbortt bbortt deleted the feature/easy-response-helpers branch November 30, 2023 12:25
novarx
novarx approved these changes Nov 30, 2023
View reviewed changes
Copy link

@novarx novarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool convenience improvement!

...-spring-boot/src/main/java/org/citrusframework/simulator/http/HttpScenarioActionBuilder.java Show resolved Hide resolved
...-spring-boot/src/main/java/org/citrusframework/simulator/http/HttpScenarioActionBuilder.java Show resolved Hide resolved
...ing-boot/src/test/java/org/citrusframework/simulator/http/HttpScenarioActionBuilderTest.java Show resolved Hide resolved
...ing-boot/src/test/java/org/citrusframework/simulator/http/HttpScenarioActionBuilderTest.java Show resolved Hide resolved
This was referenced Nov 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novarx novarx novarx approved these changes

@tschlat tschlat Awaiting requested review from tschlat

Assignees

@bbortt bbortt

Labels
java Pull requests that update Java code Prio: Medium READY TO REVIEW Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbortt @novarx