Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ShootSingleBulletBetweenCoordsIgnoreEntityNew.md #712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PichotM
Copy link
Contributor

@PichotM PichotM commented Apr 27, 2022

Updating this native to include missing params

Copy link
Contributor

@stannum-cfx stannum-cfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this will break C# backwards compatibility if params are changed, removed or added.

@stannum-cfx stannum-cfx added the changes types This pull request changes types, possibly breaking ABI compat. Needs checking. label May 5, 2022
Comment on lines +15 to +28
* **x1**: The X coordinate to start the shot at.
* **y1**: The Y coordinate to start the shot at.
* **z1**: The Z coordinate to start the shot at.
* **x2**: The X coordinate the shot should end up at.
* **y2**: The Y coordinate the shot should end up at.
* **z2**: The Z coordinate the shot should end up at.
* **damage**: The amount of damage the bullet carries.
* **pureAccuracy**: Whether the bullet should have pinpoint accuracy.
* **weaponHash**: Hash of the weapon the bullet is used as ammunition for.
* **ownerPed**: Owner of the bullet, e.g. if the bullet kills someone the kill feed shows 'X was shot by ownerPed.'
* **isAudible**: Whether the bullet should be audible. Optional, defaults to true
* **isInvisible**: Whether the bullet should be invisible. Optional, defaults to false
* **speed**: Speed the bullet should fly at. Optional
* **entity**: Entity to ignore.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice to have.

Comment on lines +33 to +35
* **p18**:
* **p19**:
* **p20**:
Copy link
Contributor

@4mmonium 4mmonium Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't add new parameters at the time being, so I would remove this.

Comment on lines -12 to -16
```
NativeDB Added Parameter 19: Any p18
NativeDB Added Parameter 20: Any p19
NativeDB Added Parameter 21: Any p20
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this back in 🙂

@@ -6,32 +6,31 @@ aliases: ["0xBFE5756E7407064A","_SHOOT_SINGLE_BULLET_BETWEEN_COORDS_WITH_EXTRA_P

```c
// 0xBFE5756E7407064A 0xCCDC33CC
void SHOOT_SINGLE_BULLET_BETWEEN_COORDS_IGNORE_ENTITY_NEW(float x1, float y1, float z1, float x2, float y2, float z2, int damage, BOOL p7, Hash weaponHash, Ped ownerPed, BOOL isAudible, BOOL isInvisible, float speed, Entity entity, BOOL p14, BOOL p15, BOOL p16, BOOL p17);
void SHOOT_SINGLE_BULLET_BETWEEN_COORDS_IGNORE_ENTITY_NEW(float x1, float y1, float z1, float x2, float y2, float z2, int damage, BOOL pureAccuracy, Hash weaponHash, Ped ownerPed, BOOL isAudible, BOOL isInvisible, float speed, Entity entity, BOOL p14, BOOL p15, BOOL p16, BOOL p17, Any p18, Any p19, Any p20);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these parameters you added , Any p18, Any p19, Any p20, but keep pureAccuracy.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I have requested some changes 😊

Copy link
Contributor

@PsychoShock PsychoShock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late, but complete now :)

@@ -6,32 +6,31 @@ aliases: ["0xBFE5756E7407064A","_SHOOT_SINGLE_BULLET_BETWEEN_COORDS_WITH_EXTRA_P

```c
// 0xBFE5756E7407064A 0xCCDC33CC
void SHOOT_SINGLE_BULLET_BETWEEN_COORDS_IGNORE_ENTITY_NEW(float x1, float y1, float z1, float x2, float y2, float z2, int damage, BOOL p7, Hash weaponHash, Ped ownerPed, BOOL isAudible, BOOL isInvisible, float speed, Entity entity, BOOL p14, BOOL p15, BOOL p16, BOOL p17);
void SHOOT_SINGLE_BULLET_BETWEEN_COORDS_IGNORE_ENTITY_NEW(float x1, float y1, float z1, float x2, float y2, float z2, int damage, BOOL pureAccuracy, Hash weaponHash, Ped ownerPed, BOOL isAudible, BOOL isInvisible, float speed, Entity entity, BOOL p14, BOOL p15, BOOL p16, BOOL p17, Any p18, Any p19, Any p20);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add that p13 (entity) can be set to false to ignore entity.

p14 -> BOOL to force to create a new projectile object.
p15 -> BOOL if it disable or not the player cover start adjustement.
p16 -> the target entity index.
p17 -> BOOL not sure what it does.
p18 -> BOOL to freeze or not the projectile waiting to hit collision. False by default.
p19 ->BOOL collision to ignore collision with entity. False by default,
p20 -> BOOL collision to ignore collision until the projectile leaves the BoundingBox of the given IgnoreEntity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p14 = bool bForceCreateNewProjectileObject
p15 = bool bDisablePlayerCoverStartAdjustment
p16 = Entity targetEntity
p17 = bool bDoDeadCheck
p18 = bool bFreezeProjectileWaitingOnCollision
p19 = bool bSetIgnoreCollisionEntity
p20 = bool bIgnoreCollisionResetNoBB

would be the correct types and names

@AvarianKnight AvarianKnight added the native import PR will be superseded by native import label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes types This pull request changes types, possibly breaking ABI compat. Needs checking. native import PR will be superseded by native import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants