Skip to content

fix(core/rdr3): block custom startup.meta file #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

Ehbw
Copy link
Contributor

@Ehbw Ehbw commented Apr 6, 2025

Goal of this PR

Fix an issue where users having a custom startup.meta file inside of their Red Dead Redemption or Red Dead Online installation would lead to the game failing to load correctly.

How is this PR achieving the goal

By preventing the game from acknowledging the files existance. Tested with problematic startup.meta file placed in x64/data/ of my Red Dead Online installation (which is used by redm). In normal conditions this file would never exist and the function would normally return false as is. So no

This PR applies to the following area(s)

RedM

Successfully tested on

Game builds: 1491

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added RedM Issues/PRs related to RedM triage Needs a preliminary assessment to determine the urgency and required action labels Apr 6, 2025
@martonp96
Copy link

Thank you for the contribution.

@martonp96 martonp96 added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Apr 7, 2025
@prikolium-cfx prikolium-cfx merged commit a711d16 into citizenfx:master Apr 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants