Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email to author data for 1.2.0 and CodeMeta output #294

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

sdruskat
Copy link
Member

@sdruskat sdruskat commented Feb 13, 2023

This PR aims to fix #285.

It adds emails to authors for

  • CFF 1.2.x
  • CFF 1.1.x
  • CFF 1.0.x

and output formats

  • CodeMeta
  • schema.org

As these are the only 2 formats including email information for authors, this can be assumed to be a complete fix for the issue.

@sdruskat
Copy link
Member Author

Hi @jspaaks, this is good to review now.
As for the CI failures: 3.6 isn't supported anymore I think, and 3.9 linting shows the same issues as in #281. I'll try to fix this in another PR.

@apirogov
Copy link

Will this eventually be merged? Just ran into problems with codemetapy just picking up email, and cffconvert just picking up orcid for the codemeta, and with the inability of codemetapy to merge, leading to information loss.

If this is merged, the workaround would be simplified to just prioritizing the codemeta output produced by cffconvert.

'___N__E': self._from_name_and_email,
'____AOE': self._from_affiliation_and_orcid_and_email,
'____A_E': self._from_affiliation_and_email,
'_____OE': self._from_orcid_and_email,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'______E' should still be added

jspaaks added a commit that referenced this pull request Jul 11, 2023
@jspaaks
Copy link
Member

jspaaks commented Jul 11, 2023

FYI I'm expanding on this in PR

@jspaaks
Copy link
Member

jspaaks commented Jul 11, 2023

Hi Stephan, thanks for your work on this. I'm merging this, and building on top of it in PR #309 FYI

@jspaaks jspaaks merged commit 163b9cf into main Jul 11, 2023
@jspaaks jspaaks deleted the 285-email-in-codemeta branch February 12, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author email address is not transferred
3 participants