-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jsonschema dependency to >=4.15.0 (replacing >3) #281
Conversation
Error causes:
|
I want to look into this soonish, but initial thoughts are I'm positive about dropping support for Python 3.6 as that is end of life. A quick scan of jsonschema's CHANGELOG suggests that will mean increasing the minimum version of |
Not sure what's going on with prospector (pylint really) but I wouldn't be surprised if I can make the error go away by raising the minimum required version on |
Would be great, although I've used |
Hi Stephan, am I right in saying that cffconvert-the-cli's behavior is unchanged by updating from say 3.2.0 to 4.17.3? But when used as a library (as I suspect was your use case), you have better diagnostics, although you have to implement them yourself, probably by wrapping If my assumption is correct, I'd like to keep Sidenote: PR #290 will also help in making the output more readable, at the command line at least, not so much when used as a library. |
Superseded by #381 |
I'm in the process of using cffconvert to analyze validation errors in a dataset of CFF files.
jsonschema
> 4 introduces a propertyjsonschema.exceptions.ValidationError
.json_path
that the currently bundled dependency (3.2.0) doesn't have. This property makes it really easy to find the offending field. I'd therefore suggest to bump thejsonschema
version to>4.15.0 <5
as per this PR. (4.15.0 is known to work.)All tests pass locally.