patch(maker): allow maker to continue after failed swapcoin recovery #412
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 70.26% 70.11% -0.16%
==========================================
Files 34 34
Lines 4261 4263 +2
==========================================
- Hits 2994 2989 -5
- Misses 1267 1274 +7 ☔ View full report in Codecov by Sentry. |
src/maker/api.rs
Outdated
| Err(ProtocolError::General(msg)) => { | ||
| log::error!("SOMETHING WENT WRONG: {}", msg); | ||
| continue; |
There was a problem hiding this comment.
If we just continue it will get stuck in the same loop. We need to remove the swapcoin from the wallet.
Also log something like "Please open an issue reporting this with logs at ".
There was a problem hiding this comment.
It does not get stuck in the recovery loop because the recovery_from_swap is called with empty vectors of outgoing and incoming contracts so it exits the recovery loop. I am able to fetch an offer and initiate a coinswap with this maker but the swap enters recovery. Trying to figure out what's going on.
2025-02-09T21:19:23.564764+05:30 ERROR coinswap::maker::api - SOMETHING WENT WRONG: Other's contract signature not known
2025-02-09T21:19:23.881322+05:30 INFO coinswap::maker::server - Total available balance for swaps: 4999700 sats | Listening for incoming swap requests
2025-02-09T21:19:24.157209+05:30 INFO coinswap::maker::api - Wallet file synced and saved to disk.
2025-02-09T21:19:24.157225+05:30 INFO coinswap::maker::api - 0 outgoing contracts detected | 0 timelock txs broadcasted.
2025-02-09T21:19:24.157234+05:30 INFO coinswap::maker::api - All outgoing transactions claimed back via timelock. Recovery loop exiting.
There was a problem hiding this comment.
I think its doing this because you still have that og-swapcoin in the wallet, which is marked as unfinished and doesn't have signature data. So it will always catch that and try to recover, and then shoot this log.
There was a problem hiding this comment.
Deleted the swapcoins. The swap with this maker is still failing. I have pushed a commit that deletes the swapcoins. I'm not sure yet, there might be something else wrong with the maker I'm running. Maybe you can checkout to this PR and attempt a swap with the affected maker.
Temporary fix to start the maker after #406