Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change get_balances signature and refactor tests #399

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

Levi0804
Copy link

@Levi0804 Levi0804 commented Feb 4, 2025

Following the discussion in #385 (comment), this PR makes the necessary changes.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (d581535) to head (7e8da53).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
src/wallet/api.rs 69.23% 4 Missing ⚠️
src/maker/rpc/server.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   70.42%   70.52%   +0.10%     
==========================================
  Files          34       34              
  Lines        4247     4248       +1     
==========================================
+ Hits         2991     2996       +5     
+ Misses       1256     1252       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean changes, thanks for taking it up. Ack.

@Levi0804
Copy link
Author

Levi0804 commented Feb 6, 2025

Happy to contribute! :D

src/wallet/api.rs Show resolved Hide resolved
@Levi0804 Levi0804 requested a review from mojoX911 February 7, 2025 20:04
Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@mojoX911 mojoX911 merged commit 5b425b5 into citadel-tech:master Feb 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants