Remove bitcoin-core binaries from repo.

[Wukong247]

Closes: #396

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (d581535) to head (a00d05a).
Report is 18 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   70.42%   70.26%   -0.17%     
==========================================
  Files          34       34              
  Lines        4247     4261      +14     
==========================================
+ Hits         2991     2994       +3     
- Misses       1256     1267      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rishkwal]

Ack. Just a thought — should we also do integrity verification of the binary?

[mojoX911]

I am not seeing the point here. Downloading bitcoind is not a user-side requirement. We only needed the binary for testing. User will run their own node.

Also this doesn't fix the github CI timeout issues for which we had the binary in the first place.

[Shourya742]

I am not seeing the point here. Downloading bitcoind is not a user-side requirement. We only needed the binary for testing. User will run their own node.

Also this doesn't fix the github CI timeout issues for which we had the binary in the first place.

This is only for testing, and the required crates added here are feature-gated. There is still a possibility of a GitHub timeout, but we can host the binary on our own server and download it from there if bitcoin.org is slow. However, including the binaries in the repository is not the right approach. I am prepared to modify the CI in case of GitHub Action timeouts.

[mojoX911]

There is still a possibility of a GitHub timeout, but we can host the binary on our own server and download it from there if bitcoin.org is slow.

Lets do that.

[mojoX911]

Ack