Feature: wallet balance api #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 78.34% 79.19% +0.84%
==========================================
Files 25 25
Lines 6045 6089 +44
==========================================
+ Hits 4736 4822 +86
+ Misses 1309 1267 -42 ☔ View full report in Codecov by Sentry. |
rajarshimaitra
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
ACK aeffd83
All looks good to me. One more conflict rebase resolution and we are good to go.
Shourya742
force-pushed
the
feature/walletBalanceApi
branch
from
bd33140 to
bfeaf1d
Compare
Shourya742
force-pushed
the
feature/walletBalanceApi
branch
from
03bb7ed to
c0e078c
Compare
This was referenced Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed is_utxo_ours method and simplified balance and list_unspent api's to individual UtxoSpentInfo.
Updated IT with new set of balance api's