Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Multiple Wallet Balance API. #91

Closed
rajarshimaitra opened this issue Feb 10, 2024 · 1 comment
Closed

[feature] Multiple Wallet Balance API. #91

rajarshimaitra opened this issue Feb 10, 2024 · 1 comment
Assignees
Milestone

Comments

@rajarshimaitra
Copy link

rajarshimaitra commented Feb 10, 2024

Currently the wallet balance API here https://github.com/utxo-teleport/teleport-transactions/blob/dda5c2d9c80cec6ccaec13b5d5038fc10c3a6d53/src/wallet/api.rs#L445-L454

Takes in two booleans to denote whether the balance should include contracts and fidelity bonds. Depending upon these two flags the balance reported would vary. If both are false it will only return the "seedcoin" balance, ie, the balance accumulated in the normal wallet received.

Task: Break the API into 3 separate APIs as per the below category

  • balance_normal(): Gives only the normal balance.
  • balance_swap_settled(): Gives the total balance accumulated in settled swapcoins.
  • balance_swap_unstteled(): Gives the total unsettled swap balance. This should report zero if there is no live contract underway.
  • balance_fidelity(): Gives the fidelity coins balance.

Scope:

@Shourya742
Copy link

Resolved with #101 and #110

@github-project-automation github-project-automation bot moved this from WIP to Done in core lib Mar 22, 2024
@mojoX911 mojoX911 removed this from core lib Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants