[Maker] Register Fidelity at Mempool

[mojoX911]

Currently, we are registering fidelity bond only when they are confirmed. This creates an edge case when the fidelity tx is in mempool and maker unexpectedly shutdown, it will loose the fund.

[KnowWhoami]

Well in order to register the fidelity bond before waiting for its confirmation -> we have to create a fidelity bond instance before looping for fidelitiy tx confirmation which requires confirmation height of this tx which can't be known before this tx got confirmed.

Also we would also need to calculate certificate expiry of the bond which is based on current block height.
and calculating this expiry value before the waiting for the confirmation may lead to misleading expiry values.

coinswap/src/wallet/fidelity.rs

Lines 428 to 443 in 6297d78

	let cert_expiry = self.get_fidelity_expiry()?;
	let bond = FidelityBond {
	outpoint: OutPoint::new(txid, 0),
	amount,
	lock_time: locktime,
	pubkey: fidelity_pubkey,
	conf_height,
	cert_expiry,
	};
	let bond_spk = bond.script_pub_key();
	self.store
	.fidelity_bond
	.insert(index, (bond, bond_spk, false));

[KnowWhoami]

One way could be just assume its confirmation height = current height +1.
and calculated the expiry values based on that?

[mojoX911]

Just change it to Option<height>?

[mojoX911]

Also we would also need to calculate certificate expiry of the bond which is based on current block height.
and calculating this expiry value before the waiting for the confirmation may lead to misleading expiry values.

Same has height. Change it to option. When in mempool these values will be None. For a valid fidelity they should always be Some.

[KnowWhoami]

Yes, I thought about but that could create another set of problems :
Let's say we created a bond instance with the conf_height as None and register this bond in the maker wallet.
Now if maker server unexpectedly shutdown while waiting for the confirmation. Then we wouldn't be able to edit the confirmation height of the bond. Thus this bond would now have None confirmation height and certificate expiry.

[mojoX911]

Yes in that case the next time the maker starts up, it should be able to identify the bond with None, wait for its confirmation then change the values.

The only thing it can do after getting a None is wait for confirmation, and don't proceed further until it's confirmed.

Even if it shuts down with the None value, it shouldn't be a problem.

[KnowWhoami]

yeah, makes sense.